OCPBUGS-57354: block upgrade if a CNI migration is in progress

[jluhrsen]

No description provided.

[openshift-ci-robot]

@jluhrsen: This pull request references Jira Issue OCPBUGS-57354, which is invalid:

• expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jluhrsen
Once this PR has been reviewed and has the lgtm label, please assign trozet for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jluhrsen]

/jira refresh
/hold
want to test locally on a real cluster upgrade/migration

[openshift-ci-robot]

@jluhrsen: This pull request references Jira Issue OCPBUGS-57354, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.0) matches configured target version for branch (4.20.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh
/hold
want to test locally on a real cluster upgrade/migration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jluhrsen]

/retest

[jluhrsen]

/retest
/hold cancel
I did some local testing and this looks like it's working as expected
/assign @kyrtapz
/assign @pliurh

[openshift-ci]

@jluhrsen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-hypershift-ovn-kubevirt	8aa8206	link	false	/test e2e-aws-hypershift-ovn-kubevirt
ci/prow/e2e-aws-ovn-serial	8aa8206	link	false	/test e2e-aws-ovn-serial
ci/prow/4.20-upgrade-from-stable-4.19-e2e-aws-ovn-upgrade	8aa8206	link	false	/test 4.20-upgrade-from-stable-4.19-e2e-aws-ovn-upgrade
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6	8aa8206	link	false	/test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/security	8aa8206	link	false	/test security
ci/prow/4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade	8aa8206	link	false	/test 4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade
ci/prow/okd-scos-e2e-aws-ovn	8aa8206	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration	8aa8206	link	false	/test e2e-aws-ovn-shared-to-local-gateway-mode-migration

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[pliurh]

@jluhrsen Thanks for this PR. We only support CNI migration in releases 4.16 and earlier. We plan to remove all migration code from CNO for 4.17+ releases. So it makes no sense to create a patch on master and backport for this feature. Could you propose this change to 4.16 branch?

[jluhrsen]

@jluhrsen Thanks for this PR. We only support CNI migration in releases 4.16 and earlier. We plan to remove all migration code from CNO for 4.17+ releases. So it makes no sense to create a patch on master and backport for this feature. Could you propose this change to 4.16 branch?

@pliurh , thanks for the info. did not know this.

here is the 4.16 version

[openshift-ci-robot]

@jluhrsen: This pull request references Jira Issue OCPBUGS-57354. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.