Skip to content

OCPBUGS-54806: Add recording rules for UDN telemetry #2697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2025
+8 −0
Merged

OCPBUGS-54806: Add recording rules for UDN telemetry #2697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions bindata/network/ovn-kubernetes/managed/alert-rules-control-plane.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ spec:
expr: max by(direction, action)(ovnkube_controller_admin_network_policies_rules)
- record: cluster:ovnkube_controller_baseline_admin_network_policies_rules:max
expr: max by(direction, action)(ovnkube_controller_baseline_admin_network_policies_rules)
- record: cluster:ovnkube_clustermanager_user_defined_networks:max
expr: max by(role, topology)(ovnkube_clustermanager_user_defined_networks)
- record: cluster:ovnkube_clustermanager_cluster_user_defined_networks:max
expr: max by(role, topology)(ovnkube_clustermanager_cluster_user_defined_networks)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tssurya I based this on the ANP metrics, but why do we do "max" here rather than returning the current value of the metric?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this will work ok. We use aggregation functions like this for telemetry to reduce the number of labels. This gets rid of any automatically added labels (container, pod, namespace and such). Since we don't really aggregate values here (since we preserve the labels that matter) it can feel a bit awkward.

Other options are sum or group_by like in

cluster-network-operator/bindata/cluster-network-operator/prometheus.yaml

Lines 15 to 18 in 2ca824b

group by (mode,is_legacy_api) (
openshift_network_operator_ipsec_state{namespace=~"openshift-network-operator"}
)
record: openshift:openshift_network_operator_ipsec_state:info

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also https://prometheus.io/docs/prometheus/latest/querying/operators/#aggregation-operators

# OVN kubernetes cluster manager functional alerts
- alert: V4SubnetAllocationThresholdExceeded
annotations:
Expand Down
4 changes: 4 additions & 0 deletions bindata/network/ovn-kubernetes/self-hosted/alert-rules-control-plane.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ spec:
expr: max by(direction, action)(ovnkube_controller_admin_network_policies_rules)
- record: cluster:ovnkube_controller_baseline_admin_network_policies_rules:max
expr: max by(direction, action)(ovnkube_controller_baseline_admin_network_policies_rules)
- record: cluster:ovnkube_clustermanager_user_defined_networks:max
expr: max by(role, topology)(ovnkube_clustermanager_user_defined_networks)
- record: cluster:ovnkube_clustermanager_cluster_user_defined_networks:max
expr: max by(role, topology)(ovnkube_clustermanager_cluster_user_defined_networks)
# OVN kubernetes cluster manager functional alerts
- alert: V4SubnetAllocationThresholdExceeded
annotations:
Expand Down