OCPBUGS-54806: Add recording rules for UDN telemetry #2697
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
jira/valid-reference
|
@danwinship: GitHub didn't allow me to request PR reviews from the following users: danwinship. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci-robot
added
the
jira/invalid-bug
|
@danwinship: This pull request references Jira Issue OCPBUGS-54806, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@danwinship: This pull request references Jira Issue OCPBUGS-54806, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
danwinship
force-pushed
the
udn-telemetry-rules
branch
from
94b5053 to
bc82c7d
Compare
| - record: cluster:ovnkube_clustermanager_user_defined_networks:max | ||
| expr: max by(role, topology)(ovnkube_clustermanager_user_defined_networks) | ||
| - record: cluster:ovnkube_clustermanager_cluster_user_defined_networks:max | ||
| expr: max by(role, topology)(ovnkube_clustermanager_cluster_user_defined_networks) |
There was a problem hiding this comment.
@tssurya I based this on the ANP metrics, but why do we do "max" here rather than returning the current value of the metric?
There was a problem hiding this comment.
Yeah this will work ok. We use aggregation functions like this for telemetry to reduce the number of labels. This gets rid of any automatically added labels (container, pod, namespace and such). Since we don't really aggregate values here (since we preserve the labels that matter) it can feel a bit awkward.
Other options are sum or group_by like in
There was a problem hiding this comment.
danwinship
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/auto-cc |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, tssurya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
1 similar comment
1 similar comment
|
/retest-required |
|
/jira refresh The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity. |
openshift-ci-robot
added
jira/invalid-bug
|
@openshift-bot: This pull request references Jira Issue OCPBUGS-54806, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@danwinship: This pull request references Jira Issue OCPBUGS-54806, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified bypass no way to validate telemetry until it's fully merged |
openshift-ci-robot
added
the
verified
|
@danwinship: The In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
/skip |
|
/retest-required |
|
/retest-required |
1 similar comment
|
/retest-required |
|
@danwinship: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
|
@danwinship: Jira Issue OCPBUGS-54806: Some pull requests linked via external trackers have merged: The following pull request, linked via external tracker, has not merged: All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-54806 has not been moved to the MODIFIED state. This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.20 |
|
@danwinship: new pull request created: #2814 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6 participants
(The metric is designed to have only the things we want for telemetry anyway, but the rules for telemetry metrics say we need an explicit recording rule anyway, so that if more info gets added to the metric later it doesn't get automatically sucked in to telemetry.)
/cc