Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-43745: Add support for IdleCloseTerminationPolicy #1166

Closed
wants to merge 3 commits into from
Closed

OCPBUGS-43745: Add support for IdleCloseTerminationPolicy #1166

wants to merge 3 commits into from

Conversation

frobware
Copy link
Contributor

@frobware frobware commented Nov 19, 2024 •
edited
Loading

Introduce logic in desiredRouterDeployment to set the environmentvariable ROUTER_IDLE_CLOSE_ON_RESPONSE when the IdleConnectionTerminationPolicy field in the IngressController spec is set to Deferred. This change enables configuring HAProxy with the idle-close-on-response option for better control over idle connection termination behaviour.

Requires:

@openshift-ci openshift-ci bot requested review from alebedev87 and Miciah November 19, 2024 15:19
@frobware frobware changed the title OCPBUGS 43745 idle close on response OCPBUGS:43745: idle close on response Nov 19, 2024
@frobware frobware changed the title OCPBUGS:43745: idle close on response OCPBUGS-43745: idle close on response Nov 19, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 19, 2024
@openshift-ci-robot
Copy link
Contributor

@frobware: This pull request references Jira Issue OCPBUGS-43745, which is invalid:

  • expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.19.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@frobware
Copy link
Contributor Author

/hold

Many commits should never merge.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2024
@frobware frobware force-pushed the OCPBUGS-43745-idle-close-on-response branch from a7dea46 to 991d367 Compare November 20, 2024 15:53
@frobware
Copy link
Contributor Author

/testwith openshift/cluster-ingress-operator/release-4.18/e2e-aws-operator openshift/router#639

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 20, 2024

@frobware, testwith: could not generate prow job. ERROR:

no ref for requested test included in command

@frobware
Copy link
Contributor Author

/testwith openshift/cluster-ingress-operator/master/e2e-aws-operator openshift/router#639

@frobware frobware changed the title OCPBUGS-43745: idle close on response OCPBUGS-43745: Add support for IdleCloseTerminationPolicy Nov 20, 2024
@frobware frobware force-pushed the OCPBUGS-43745-idle-close-on-response branch from 991d367 to 052f6b6 Compare November 20, 2024 19:23
@frobware frobware mentioned this pull request Nov 21, 2024
Merged
@frobware frobware force-pushed the OCPBUGS-43745-idle-close-on-response branch from 052f6b6 to 0aa6244 Compare November 21, 2024 07:47
@frobware
Copy link
Contributor Author

/testwith openshift/cluster-ingress-operator/master/e2e-aws-operator openshift/router#639

@frobware frobware force-pushed the OCPBUGS-43745-idle-close-on-response branch from 0aa6244 to 1072f8f Compare November 21, 2024 08:04
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 27, 2024
@frobware frobware force-pushed the OCPBUGS-43745-idle-close-on-response branch 2 times, most recently from f89fbb2 to 9707f72 Compare December 10, 2024 13:44
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 10, 2024
@frobware
Copy link
Contributor Author

/testwith openshift/cluster-ingress-operator/master/e2e-aws-operator openshift/router#639

@frobware frobware force-pushed the OCPBUGS-43745-idle-close-on-response branch from 9707f72 to 77673b3 Compare December 10, 2024 14:49
@frobware
Copy link
Contributor Author

/testwith openshift/cluster-ingress-operator/master/e2e-aws-operator openshift/router#639

@frobware frobware force-pushed the OCPBUGS-43745-idle-close-on-response branch from 77673b3 to 3029807 Compare December 10, 2024 15:43
@alebedev87
Copy link
Contributor

/assign

@frobware
Copy link
Contributor Author

/test e2e-aws-operator

@frobware
Copy link
Contributor Author

/test hypershift-e2e-aks

This was referenced Jan 10, 2025
Closed
Closed
@frobware
Copy link
Contributor Author

Test_IdleConnectionTerminationPolicy is flaking - trying to understand how often in #1178

@frobware
Copy link
Contributor Author

Re: e2e-aws-operator. Last failure was: TestAll/serial/TestRouterCompressionOperation; https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_cluster-ingress-operator/1166/pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-operator/1877632761573937152/artifacts/e2e-aws-operator/test/build-log.txt

@frobware
Copy link
Contributor Author

/test e2e-aws-operator

@frobware
Copy link
Contributor Author

Test_IdleConnectionTerminationPolicy is flaking - trying to understand if moving it to the serial test suite would makes things better in #1177.

@frobware frobware mentioned this pull request Jan 10, 2025
Closed
@frobware frobware force-pushed the OCPBUGS-43745-idle-close-on-response branch from f61bdaf to 039d723 Compare January 13, 2025 14:14
@frobware
Copy link
Contributor Author

/testwith openshift/cluster-ingress-operator/master/e2e-aws-operator openshift/router#639

@frobware
OCPBUGS-43745: vendor openshift/api#2102
9a6016e 
Pickup openshift/api#2102

% git show 27316471eb72fe8fcf0d44fb5a0602f698f253dc
commit 27316471eb72fe8fcf0d44fb5a0602f698f253dc
Merge: de9de05a8 b7417509c
Author: openshift-merge-bot[bot] <148852131+openshift-merge-bot[bot]@users.noreply.github.com>
Date:   Wed Dec 18 10:31:50 2024 +0000

    Merge pull request #2102 from frobware/OCPBUGS-43745-idle-close-on-response

    OCPBUGS-43745: Add IdleCloseOnResponse field to IngressControllerSpec

Vendor steps:

$ go mod edit -replace github.com/openshift/api=github.com/openshift/api@27316471eb72fe8fcf0d44fb5a0602f698f253dc
$ go mod tidy
$ go mod vendor
$ make update
@frobware frobware force-pushed the OCPBUGS-43745-idle-close-on-response branch from 039d723 to 19d9be9 Compare January 13, 2025 16:50
@frobware
Copy link
Contributor Author

/testwith openshift/cluster-ingress-operator/master/e2e-aws-operator openshift/router#639

@frobware frobware mentioned this pull request Jan 13, 2025
Closed
@frobware frobware force-pushed the OCPBUGS-43745-idle-close-on-response branch from 19d9be9 to 7b20e04 Compare January 13, 2025 18:11
@frobware
OCPBUGS-43745: Add support for idle connection termination policy
c0d9605 
Introduce logic in desiredRouterDeployment to set the environment
variable `ROUTER_IDLE_CLOSE_ON_RESPONSE` when the
`IdleConnectionTerminationPolicy` field in the IngressController spec is
set to `Deferred`. This change enables configuring HAProxy with the
`idle-close-on-response` option for better control over idle connection
termination behaviour.
@frobware frobware force-pushed the OCPBUGS-43745-idle-close-on-response branch from 7b20e04 to c0d9605 Compare January 13, 2025 18:12
@frobware frobware mentioned this pull request Jan 13, 2025
Merged
@frobware
Copy link
Contributor Author

/retest

@frobware frobware mentioned this pull request Jan 14, 2025
Closed
@frobware
Copy link
Contributor Author

/retest

@frobware
Copy link
Contributor Author

/testwith openshift/cluster-ingress-operator/master/e2e-aws-operator openshift/router#639

@frobware
Copy link
Contributor Author

/retest-required

@frobware
Copy link
Contributor Author

/testwith openshift/cluster-ingress-operator/master/e2e-aws-operator openshift/router#639

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 15, 2025

@frobware: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-gatewayapi c0d9605 link false /test e2e-aws-gatewayapi
ci/prow/e2e-aws-operator c0d9605 link true /test e2e-aws-operator
ci/prow/e2e-azure-ovn c0d9605 link false /test e2e-azure-ovn
ci/prow/e2e-gcp-ovn c0d9605 link false /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-serial c0d9605 link true /test e2e-aws-ovn-serial
ci/prow/e2e-aws-operator-techpreview c0d9605 link false /test e2e-aws-operator-techpreview
ci/prow/e2e-hypershift c0d9605 link true /test e2e-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frobware
Copy link
Contributor Author

Closing this post a discussion with @alebedev87 - the rigidity of the connection state in the test steps and expectations can never hold true when the dynamic config manager (DCM) is enabled. Moving to #1182.

@frobware frobware closed this Jan 15, 2025
@openshift-ci-robot
Copy link
Contributor

@frobware: This pull request references Jira Issue OCPBUGS-43745. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Introduce logic in desiredRouterDeployment to set the environmentvariable ROUTER_IDLE_CLOSE_ON_RESPONSE when the IdleConnectionTerminationPolicy field in the IngressController spec is set to Deferred. This change enables configuring HAProxy with the idle-close-on-response option for better control over idle connection termination behaviour.

Requires:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@frobware frobware mentioned this pull request Jan 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alebedev87 alebedev87 alebedev87 left review comments

@Miciah Miciah Awaiting requested review from Miciah

@lihongan lihongan Awaiting requested review from lihongan

Assignees

@alebedev87 alebedev87

@grzpiotrowski grzpiotrowski

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@frobware @openshift-ci-robot @alebedev87 @candita @openshift-merge-robot @grzpiotrowski