Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.18] OCPBUGS-48383: Add support for IdleCloseTerminationPolicy #1183

Closed
wants to merge 4 commits into from
Closed

[release-4.18] OCPBUGS-48383: Add support for IdleCloseTerminationPolicy #1183

wants to merge 4 commits into from

Conversation

frobware
Copy link
Contributor

  • test/http2: enhance response handlers
  • OCPBUGS-48383: DO NOT MERGE: vendor github.com/frobware/api
  • OCPBUGS-43745: Add support for idle connection termination policy
  • deployment_test.go: 4.18 conflicts

@frobware
test/http2: enhance response handlers
b6c9324 
Enhanced response handlers (`/` and `/healthz`) to include
pod-specific headers (`x-pod-name` and `x-pod-namespace`).

Introduced new environment variables to control HTTP and HTTPS listeners:
- `HTTP2_TEST_SERVER_ENABLE_HTTP_LISTENER`: Enables/disables the HTTP listener.
- `HTTP2_TEST_SERVER_ENABLE_HTTPS_LISTENER`: Enables/disables the HTTPS listener.

Improved error handling to log and terminate if no listeners are
enabled, providing flexibility in determining which listeners to
activate.
@frobware
OCPBUGS-48383: DO NOT MERGE: vendor github.com/frobware/api
2652965 
Picking up: openshift/api#2146

Vendor steps:

$ go mod edit -replace github.com/openshift/api=github.com/frobware/api@2d7c828eaefe393b7908cc762b8b772ffd04f3db
$ go mod tidy
$ go mod vendor
$ make update
@frobware
OCPBUGS-43745: Add support for idle connection termination policy
2b577fe 
Introduce logic in desiredRouterDeployment to set the environment
variable `ROUTER_IDLE_CLOSE_ON_RESPONSE` when the
`IdleConnectionTerminationPolicy` field in the IngressController spec is
set to `Deferred`. This change enables configuring HAProxy with the
`idle-close-on-response` option for better control over idle connection
termination behaviour.
@frobware
deployment_test.go: 4.18 conflicts
dbfe58f
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 14, 2025
@openshift-ci-robot
Copy link
Contributor

@frobware: This pull request references Jira Issue OCPBUGS-48383, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-43745 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead
  • expected dependent Jira Issue OCPBUGS-43745 to target a version in 4.19.0, but it targets "4.19" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

  • test/http2: enhance response handlers
  • OCPBUGS-48383: DO NOT MERGE: vendor github.com/frobware/api
  • OCPBUGS-43745: Add support for idle connection termination policy
  • deployment_test.go: 4.18 conflicts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from miheer and Thealisyed January 14, 2025 15:07
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from frobware. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@frobware
Copy link
Contributor Author

/testwith openshift/cluster-ingress-operator/release-4.18/e2e-aws-operator penshift/router#647

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 14, 2025

@frobware, testwith: Error processing request. ERROR:

could not determine job runs: couldn't get PR from GitHub: penshift/router#647: Get "http://ghproxy/repos/penshift/router/pulls/647": failed to get installation id for org penshift: the github app is not installed in organization penshift

@frobware
Copy link
Contributor Author

/testwith openshift/cluster-ingress-operator/release-4.18/e2e-aws-operator openshift/router#647

@frobware
Copy link
Contributor Author

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 15, 2025

@frobware: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node dbfe58f link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-operator-techpreview dbfe58f link false /test e2e-aws-operator-techpreview
ci/prow/e2e-azure-operator dbfe58f link true /test e2e-azure-operator
ci/prow/okd-scos-e2e-aws-ovn dbfe58f link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp-operator dbfe58f link true /test e2e-gcp-operator
ci/prow/e2e-aws-ovn-serial dbfe58f link true /test e2e-aws-ovn-serial
ci/prow/e2e-aws-operator dbfe58f link true /test e2e-aws-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frobware
Copy link
Contributor Author

This 4.18 backport needs to be reworked based on #1166 (comment).

@frobware frobware closed this Jan 15, 2025
@openshift-ci-robot
Copy link
Contributor

@frobware: This pull request references Jira Issue OCPBUGS-48383. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

  • test/http2: enhance response handlers
  • OCPBUGS-48383: DO NOT MERGE: vendor github.com/frobware/api
  • OCPBUGS-43745: Add support for idle connection termination policy
  • deployment_test.go: 4.18 conflicts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miheer miheer Awaiting requested review from miheer

@Thealisyed Thealisyed Awaiting requested review from Thealisyed

Assignees
No one assigned
Labels
jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frobware @openshift-ci-robot