Skip to content

Fix flaky Test IndexServiceTests.testBaseAsyncTaskWithFixedIntervalEnabledAndLongerRefresh #20077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2025
+8 −8
Merged

Fix flaky Test IndexServiceTests.testBaseAsyncTaskWithFixedIntervalEnabledAndLongerRefresh #20077

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions server/src/test/java/org/opensearch/index/IndexServiceTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,14 +748,14 @@ protected void runInternal() {
}
) {
// In zero state, we have a random sleep duration
long sleepDurationMs = task.getSleepDuration().millis();
assertTrue(sleepDurationMs > 0);
long sleepDurationNanos = task.getSleepDuration().nanos();
assertTrue(sleepDurationNanos > 0);
task.run();
latch.await();
// Since we have refresh taking up 2s, then the next refresh should have sleep duration of 3s. Here we check
// the sleep duration to be non-zero since the sleep duration is calculated dynamically.
sleepDurationMs = task.getSleepDuration().millis();
assertTrue(sleepDurationMs > 0);
sleepDurationNanos = task.getSleepDuration().nanos();
assertTrue(sleepDurationNanos > 0);
assertEquals(0, latch.getCount());
indexService.close("test", false);
assertBusy(() -> { assertEquals(TimeValue.ZERO, task.getSleepDuration()); });
Expand Down Expand Up @@ -783,14 +783,14 @@ protected void runInternal() {
}
) {
// In zero state, we have a random sleep duration
long sleepDurationMs = task.getSleepDuration().millis();
assertTrue(sleepDurationMs > 0);
long sleepDurationNanos = task.getSleepDuration().nanos();
assertTrue(sleepDurationNanos > 0);
task.run();
latch.await();
indexService.close("test", false);
// Since we have refresh taking up 2s and refresh interval as 1s, then the next refresh should happen immediately.
sleepDurationMs = task.getSleepDuration().millis();
assertEquals(0, sleepDurationMs);
sleepDurationNanos = task.getSleepDuration().nanos();
assertEquals(0, sleepDurationNanos);
assertEquals(0, latch.getCount());
}
}
Expand Down
Loading