Fix flaky Test IndexServiceTests.testBaseAsyncTaskWithFixedIntervalEnabledAndLongerRefresh #20077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abledAndLongerRefresh Signed-off-by: kkewwei <[email protected]> Signed-off-by: kkewwei <[email protected]>
kkewwei
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
github-actions
bot
added
>test-failure
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20077 +/- ##
============================================
- Coverage 73.33% 73.33% -0.01%
- Complexity 71679 71689 +10
============================================
Files 5790 5790
Lines 327549 327549
Branches 47181 47181
============================================
- Hits 240217 240208 -9
- Misses 68080 68096 +16
+ Partials 19252 19245 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@andrross Would you mind have a look in your spare time? |
gaobinlong
approved these changes
Nov 27, 2025
kkewwei
added a commit
to kkewwei/OpenSearch
that referenced
this pull request
Nov 28, 2025
…abledAndLongerRefresh (opensearch-project#20077) Signed-off-by: kkewwei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
IndexServiceTests.testBaseAsyncTaskWithFixedIntervalEnabledAndLongerRefreshand in zero state, we have a random sleep duration. It's created by theinterval.nanos()and may be less than a millisecond.At the outer layer, we will verify whether the input is in milliseconds. If it is, an exception will be thrown.
This also applies to
testBaseAsyncTaskWithFixedIntervalEnabled.Related Issues
Resolves partial flaky tests in #14407
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.