Skip to content

Compare JavaType.Method.name before declaringType in equals(Object) #5977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2025
Merged

Compare JavaType.Method.name before declaringType in equals(Object) #5977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebf14f9
Compare `JavaType.Method.name` before `declaringType` in `equals(Obje…
timtebeek Aug 29, 2025
932fa3a
Comment out RemoveSystemOutPrintln
timtebeek Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rewrite-java/src/main/java/org/openrewrite/java/tree/JavaType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1565,8 +1565,8 @@ public boolean equals(Object o) {
if (this == o) return true;
if (o == null || getClass() != o.getClass()) return false;
Method method = (Method) o;
return Objects.equals(declaringType, method.declaringType) &&
name.equals(method.name) &&
return Objects.equals(name, method.name) &&
Objects.equals(declaringType, method.declaringType) &&
Objects.equals(returnType, method.returnType) &&
Arrays.equals(parameterTypes, method.parameterTypes);
}
Expand Down
2 changes: 1 addition & 1 deletion rewrite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ recipeList:
- org.openrewrite.java.recipes.UseTreeRandomId
- org.openrewrite.java.recipes.migrate.RemoveTraitsUsageRecipes
- org.openrewrite.staticanalysis.NeedBraces
- org.openrewrite.staticanalysis.RemoveSystemOutPrintln
# - org.openrewrite.staticanalysis.RemoveSystemOutPrintln
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intended?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, didn't want to keep patching main when folks as print statements to test code.

# - org.openrewrite.java.RemoveAnnotation:
# annotationPattern: '@org.openrewrite.NlsRewrite.DisplayName'
# - org.openrewrite.java.RemoveAnnotation:
Expand Down