Compare JavaType.Method.name before declaringType in equals(Object)

[timtebeek]

As discovered on

• fix RemoveUnusedPrivateMethods: getHostDottedClassName rewrite-static-analysis#727 (comment)

Before we had

rewrite/rewrite-java/src/main/java/org/openrewrite/java/tree/JavaType.java

Lines 1563 to 1572 in 8ce5308

	@Override
	public boolean equals(Object o) {
	if (this == o) return true;
	if (o == null || getClass() != o.getClass()) return false;
	Method method = (Method) o;
	return Objects.equals(declaringType, method.declaringType) &&
	name.equals(method.name) &&
	Objects.equals(returnType, method.returnType) &&
	Arrays.equals(parameterTypes, method.parameterTypes);
	}

Which then led to calling equals on the declaringType first, which for FullyQualified.Class looks like:

rewrite/rewrite-java/src/main/java/org/openrewrite/java/tree/JavaType.java

Lines 576 to 583 in 8ce5308

	@Override
	public boolean equals(Object o) {
	if (this == o) return true;
	if (o == null || getClass() != o.getClass()) return false;
	Class aClass = (Class) o;
	return TypeUtils.fullyQualifiedNamesAreEqual(fullyQualifiedName, aClass.fullyQualifiedName) &&
	(typeParameters == null && aClass.typeParameters == null || typeParameters != null && Arrays.equals(typeParameters, aClass.typeParameters));
	}

Whereas the name is just a String that we can more cheaply compare and reject, making it unnecessary to do name comparisons first in
https://github.com/openrewrite/rewrite-static-analysis/blob/232339c63ac81a5e47275a093beb845154b6f745/src/main/java/org/openrewrite/staticanalysis/RemoveUnusedPrivateMethods.java#L96-L98

[github-actions]

Some suggestions could not be made:

• rewrite-javascript/src/integTest/java/org/openrewrite/javascript/rpc/JavaScriptRewriteRpcTest.java
  • lines 36-36
  • lines 66-66

[greg-at-moderne]

Was this intended?

[timtebeek]

Yes, didn't want to keep patching main when folks as print statements to test code.