Validate written classes if enabled, and fix reported issues

[timtebeek]

What's changed?

When VERIFY_CLASS_WRITING was set to true, we would not validate, while we should.

What's your motivation?

Seeing downstream failures in rewrite-hibernate that had failed to replicate here

• Failure to write out type table for nested types in hibernate-core:6.5.1.Final #4993

[timtebeek]

Reporting the next failure here: https://ge.openrewrite.org/s/lxo3gtzucpq3c/tests/task/:rewrite-java:test/details/org.openrewrite.java.internal.parser.TypeTableTest/writeReadMicrometer()?top-execution=1
Looks like we're writing out incomplete class files; on the upside the downstream projects can use them as-is though. 🤔

java.lang.IllegalArgumentException: Execution can fall off the end of the code <init>(Ljava/lang/String;Ljava/lang/Throwable;)V	
at org.objectweb.asm.util.CheckMethodAdapter$1.throwError(CheckMethodAdapter.java:489)	
at org.objectweb.asm.util.CheckMethodAdapter$1.visitEnd(CheckMethodAdapter.java:475)	
at org.objectweb.asm.MethodVisitor.visitEnd(MethodVisitor.java:797)	
at org.objectweb.asm.util.CheckMethodAdapter.visitEnd(CheckMethodAdapter.java:1044)	
at org.openrewrite.java.internal.parser.TypeTable$Reader.lambda$writeClassesDir$3(TypeTable.java:226)	
at org.openrewrite.java.internal.parser.TypeTable$Reader$$Lambda$908/0x00007f3af0544870.accept(Unknown Source)	
at java.util.HashMap.forEach(HashMap.java:1421)	
at org.openrewrite.java.internal.parser.TypeTable$Reader.writeClassesDir(TypeTable.java:180)	
at org.openrewrite.java.internal.parser.TypeTable$Reader.read(TypeTable.java:169)	
at org.openrewrite.java.internal.parser.TypeTable.<init>(TypeTable.java:97)	
at org.openrewrite.java.internal.parser.TypeTableTest.writeReadMicrometer(TypeTableTest.java:107)	
at java.lang.reflect.Method.invoke(Method.java:569)	
at java.util.ArrayList.forEach(ArrayList.java:1511)	
at java.util.ArrayList.forEach(ArrayList.java:1511)	
Caused by: org.objectweb.asm.tree.analysis.AnalyzerException: Execution can fall off the end of the code	
at org.objectweb.asm.tree.analysis.Analyzer.findSubroutine(Analyzer.java:425)	
at org.objectweb.asm.tree.analysis.Analyzer.findSubroutines(Analyzer.java:381)	
at org.objectweb.asm.tree.analysis.Analyzer.analyze(Analyzer.java:137)	
at org.objectweb.asm.util.CheckMethodAdapter$1.visitEnd(CheckMethodAdapter.java:470)	
at org.objectweb.asm.MethodVisitor.visitEnd(MethodVisitor.java:797)	
at org.objectweb.asm.util.CheckMethodAdapter.visitEnd(CheckMethodAdapter.java:1044)	
at org.openrewrite.java.internal.parser.TypeTable$Reader.lambda$writeClassesDir$3(TypeTable.java:226)	
at org.openrewrite.java.internal.parser.TypeTable$Reader$$Lambda$908/0x00007f3af0544870.accept(Unknown Source)	
at java.util.HashMap.forEach(HashMap.java:1421)	
at org.openrewrite.java.internal.parser.TypeTable$Reader.writeClassesDir(TypeTable.java:180)	
at org.openrewrite.java.internal.parser.TypeTable$Reader.read(TypeTable.java:169)	
at org.openrewrite.java.internal.parser.TypeTable.<init>(TypeTable.java:97)	
at org.openrewrite.java.internal.parser.TypeTableTest.writeReadMicrometer(TypeTableTest.java:107)	
at java.lang.reflect.Method.invoke(Method.java:569)	
at java.util.ArrayList.forEach(ArrayList.java:1511)	
at java.util.ArrayList.forEach(ArrayList.java:1511)