Failure to write out type table for nested types in hibernate-core:6.5.1.Final

[timtebeek]

What version of OpenRewrite are you using?

I am using

• OpenRewrite 8.45.0-SNAPSHOT

How are you running OpenRewrite?

I'm running ./gradlew createTypeTable against openrewrite/rewrite-hibernate through a locally installed version of this build plugin

• Add task to create type tables to replace resource jars rewrite-build-gradle-plugin#75

What is the smallest, simplest way to reproduce the problem?

1. Checkout this branch Add task to create type tables to replace resource jars rewrite-build-gradle-plugin#75
2. Run ./gradlew pTML on said branch
3. Checkout openrewrite/rewrite-hibernate
4. Change settings.gradle.kts to add

pluginManagement {
    repositories {
        mavenLocal()
        gradlePluginPortal()
    }
}

5. Change build.gradle.kts to use recipe-library version latest.integration
6. Run ./gradlew createTypeTable
7. Delete src/main/resources/META-INF/rewrite/classpath
8. Run the unit tests

What did you expect to see?

A successfully created type table used to pass the unit tests.

What did you see instead?

A failure to run the unit tests

What is the full stack trace of any errors you encountered?

java.lang.IllegalArgumentException: Invalid access flags: 32

	at org.objectweb.asm.util.CheckClassAdapter.checkAccess(CheckClassAdapter.java:542)
	at org.objectweb.asm.util.CheckClassAdapter.visitInnerClass(CheckClassAdapter.java:363)
	at org.openrewrite.java.internal.parser.TypeTable$Reader.lambda$writeClassesDir$3(TypeTable.java:207)
	at java.base/java.util.HashMap.forEach(HashMap.java:1421)
	at org.openrewrite.java.internal.parser.TypeTable$Reader.writeClassesDir(TypeTable.java:180)
	at org.openrewrite.java.internal.parser.TypeTable$Reader.read(TypeTable.java:169)
	at org.openrewrite.java.internal.parser.TypeTable.<init>(TypeTable.java:97)
	at org.openrewrite.java.internal.parser.TypeTable.fromClasspath(TypeTable.java:89)
	at org.openrewrite.java.JavaParser.dependenciesFromResources(JavaParser.java:130)
	at org.openrewrite.java.JavaParser$Builder.classpathFromResources(JavaParser.java:331)
	at org.openrewrite.hibernate.MigrateUserTypeTest.defaults(MigrateUserTypeTest.java:33)
	at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:137)
	at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:129)
	at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:124)
	at org.openrewrite.hibernate.MigrateUserTypeTest.shouldMigrateUserType(MigrateUserTypeTest.java:41)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

When attempting to write out these values with ASM.

[timtebeek]

Notice above how the outerName has no relation to the class being written; I suppose we need to change these lines

rewrite/rewrite-java/src/main/java/org/openrewrite/java/internal/parser/TypeTable.java

Lines 206 to 213 in 7661418

	for (ClassDefinition innerClass : innerClasses) {
	classWriter.visitInnerClass(
	innerClass.getName(),
	classDef.getName(),
	innerClass.getName().substring(innerClass.getName().lastIndexOf('$') + 1),
	innerClass.getAccess()
	);
	}

to

                for (ClassDefinition innerClass : innerClasses) {
                    int lastIndexOf$ = innerClass.getName().lastIndexOf('$');
                    classWriter.visitInnerClass(
                            innerClass.getName(),
                            innerClass.getName().substring(0, lastIndexOf$),
                            innerClass.getName().substring(lastIndexOf$ + 1),
                            innerClass.getAccess()
                    );
                }

but even then we see the same access issues in org.objectweb.asm.util.CheckClassAdapter#checkAccess.

[jkschneider]

@timtebeek I think it may be sufficient to just bitwise NOT out the flags that shouldn't be written in this case.

[timtebeek]

There's a few more issues it seems; the tests were running without validation

• Validate written classes if enabled, and fix reported issues #4999