-
Notifications
You must be signed in to change notification settings - Fork 1
add mapping.proto. rename and move tenant system link methods. add ty… #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
NamanBalaji
merged 4 commits into
feat/api-changes-for-system-sepration
from
feat/api-changes-for-system-sepration-and-tenant-mapping
Dec 17, 2025
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
666 changes: 666 additions & 0 deletions
666
proto/kms/api/cmk/registry/mapping/v1/mapping.pb.validate.go
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| syntax = "proto3"; | ||
|
|
||
| package kms.api.cmk.registry.mapping.v1; | ||
|
|
||
| service Service { | ||
| rpc UnmapSystemFromTenant(UnmapSystemFromTenantRequest) returns (UnmapSystemFromTenantResponse) {} | ||
| rpc MapSystemToTenant(MapSystemToTenantRequest) returns (MapSystemToTenantResponse) {} | ||
| rpc Get(GetRequest) returns (GetResponse) {} | ||
| } | ||
|
|
||
| message UnmapSystemFromTenantRequest { | ||
| string external_id = 10; | ||
| string type = 20; | ||
| string tenant_id = 30; | ||
| } | ||
|
|
||
| message UnmapSystemFromTenantResponse { | ||
| bool success = 10; | ||
| } | ||
|
|
||
| message MapSystemToTenantRequest { | ||
| string external_id = 10; | ||
| string type = 20; | ||
| string tenant_id = 30; | ||
| } | ||
|
|
||
| message MapSystemToTenantResponse { | ||
| bool success = 10; | ||
| } | ||
|
|
||
| message GetRequest { | ||
| string external_id = 10; | ||
| string type = 20; | ||
| } | ||
|
|
||
| message GetResponse { | ||
| string tenant_id = 10; | ||
| } | ||
197 changes: 197 additions & 0 deletions
197
proto/kms/api/cmk/registry/mapping/v1/mapping_grpc.pb.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need a
tenant_idhere ? If this method is replacing unlink tenant we never requiredtenant_idthere.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically we don't need it, but in the discussion Today we aligned to send it, so we don't accidentally unmap something unexpected.