add mapping.proto. rename and move tenant system link methods. add ty…#72
Merged
NamanBalaji merged 4 commits intofeat/api-changes-for-system-seprationfrom Dec 17, 2025
Conversation
…pe as optional parameter.
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
cb80
requested changes
Dec 17, 2025
Contributor
cb80
left a comment
cb80
left a comment
There was a problem hiding this comment.
Please create a v1 subdirectory under mapping
cb80
approved these changes
Dec 17, 2025
|
NamanBalaji
merged commit d216efd
into
feat/api-changes-for-system-sepration
7 of 8 checks passed
NamanBalaji
deleted the
feat/api-changes-for-system-sepration-and-tenant-mapping
branch
NamanBalaji
reviewed
Dec 17, 2025
| message UnmapSystemFromTenantRequest { | ||
| string external_id = 10; | ||
| string type = 20; | ||
| string tenant_id = 30; |
Contributor
There was a problem hiding this comment.
Why do we need a tenant_id here ? If this method is replacing unlink tenant we never required tenant_id there.
Contributor
There was a problem hiding this comment.
Technically we don't need it, but in the discussion Today we aligned to send it, so we don't accidentally unmap something unexpected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.