-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove 'patch-package' and its unused frontend-build patch #1621
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @bradenmacdonald! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1621 +/- ##
=======================================
Coverage 84.72% 84.72%
=======================================
Files 333 333
Lines 5709 5709
Branches 1368 1368
=======================================
Hits 4837 4837
Misses 855 855
Partials 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, approved!
Let's wait a couple of days for somebody at 2U to give their ok before merging, though.
@jansenk @jristau1984 We never heard back from you on this PR - could you please take a look and confirm it won't negatively affect 2U if we merge? Thanks! Slack thread |
This reverts #1350 which added a patch to
frontend-build
to support aJS_CONFIG_FILEPATH
env variable. I don't think it's used, but if 2U is still using this functionality, it's overdue to be merged into frontend-build instead of maintained on this patch.