Skip to content

Conversation

@garaud
Copy link
Contributor

@garaud garaud commented Jul 7, 2025

Migrate the plugin for Elastic 8.18.1

  • apply spotless formatting

  • update the elasticsearch version to 8.18.1

  • Adapt the plugin to Elastic 8

    Thanks to @nicenatalia

    Co-authored-by: Natalia Escalera [email protected]

  • update the LICENSE to AGPL

  • add the yaml REST test framework dependency to the build.gradle file

@garaud garaud requested review from 5k4nd and Copilot July 7, 2025 10:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Migrate the path hierarchy plugin to Elastic 8.18.1 with formatting updates, version bump, and license change

  • Bump Elasticsearch and plugin versions to 8.18.1 and apply spotless formatting
  • Update license from MIT to AGPL and adjust README
  • Refactor builder and aggregator classes to multiline argument style and remove deprecated imports

Reviewed Changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
gradle.properties Updated es_version and plugin_version to 8.18.1
README.md Changed license statement to AGPL
LICENSE Replaced MIT license text with AGPL v3 full text
src/yamlRestTest/java/org/opendatasoft/elasticsearch/RestApiYamlIT.java Added missing import for parameterized tests
src/test/java/org/opendatasoft/elasticsearch/PathHierarchyTests.java Inlined JSON strings in test setup
src/main/java/org/opendatasoft/elasticsearch/search/aggregations/bucket/PathSortedTree.java Removed extraneous blank lines
src/main/java/org/opendatasoft/elasticsearch/search/aggregations/bucket/*.java Reformatted constructors and method calls to multiline style; removed deprecated imports
Comments suppressed due to low confidence (3)

src/test/java/org/opendatasoft/elasticsearch/PathHierarchyTests.java:19

  • [nitpick] The variable name orders is a JSON string rather than a list; consider renaming to orderJson for clarity.
        String orders = "[{\"_key\": \"asc\"}, {\"_count\": \"desc\"}]";

src/main/java/org/opendatasoft/elasticsearch/search/aggregations/bucket/PathHierarchyAggregationBuilder.java:35

  • Consider adding a unit test to verify that getMinimalSupportedVersion() returns TransportVersions.V_8_0_0 as expected.
    public TransportVersion getMinimalSupportedVersion() {

src/main/java/org/opendatasoft/elasticsearch/search/aggregations/bucket/DateHierarchyAggregationBuilder.java:149

  • [nitpick] The comment references timezoneAware which is no longer a parameter; please update or remove it to avoid confusion.
        // ES 8.x introduces field validation. Setting timezoneAware to false to avoid duplication of the timezone field

@5k4nd
Copy link
Contributor

5k4nd commented Aug 13, 2025

@garaud I didn't manage to track the cluster info issue yet. I've added a test which is failing here and working on master (7.17.28).
The issue is: api [info] returned [405 Method Not Allowed]

@5k4nd 5k4nd merged commit 4e33871 into master Oct 8, 2025
1 check passed
@5k4nd 5k4nd deleted the chore/sc-43372/migrate-es-path-hierarchy-java-plugin branch October 8, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants