Skip to content

test(GUI): enable account test #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Asmitapaudel wants to merge 1 commit into from
Closed

test(GUI): enable account test #920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/gui/features/add-account/account.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Feature: adding accounts
Then "Brian" account should be opened
And "Alice" account should be added


@smoke
Copy link
Copy Markdown
Contributor

@saw-jan saw-jan May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not a smoke test. Now, the workflow should be:

  • skip all the tests that are not tagged @smoke
  • fix and enable skipped tests
  • in CI, run tests that are not marked @skip
Suggested change
@smoke

Scenario: Adding account with self signed certificate for the first time
Given the user has started the client
When the user adds the server "%local_server%"
Expand Down
7 changes: 5 additions & 2 deletions test/gui/pageObjects/AccountConnectionWizard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class AccountConnectionWizard:
selector="QApplication.Settings.centralwidget.dialogStack.SetupWizardWidget.contentWidget.AccountConfiguredWizardPage.advancedConfigGroupBox.advancedConfigGroupBoxContentWidget.localDirectoryGroupBox.chooseLocalDirectoryButton",
)
CHOOSE_FOLDER_BUTTON = SimpleNamespace(by=By.NAME, selector="Choose")
OAUTH_CREDENTIAL_PAGE = SimpleNamespace(by=None, selector=None)
OAUTH_CREDENTIAL_PAGE = SimpleNamespace(by=By.XPATH, selector="//label[@name='Log in with your web browser']")
Copy link
Copy Markdown
Contributor

@saw-jan saw-jan May 28, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
OAUTH_CREDENTIAL_PAGE = SimpleNamespace(by=By.XPATH, selector="//label[@name='Log in with your web browser']")
LOGIN_DIALOG = SimpleNamespace(by=By.XPATH, selector="//label[@name='Log in with your web browser']")

COPY_URL_TO_CLIPBOARD_BUTTON = SimpleNamespace(
by=By.NAME,
selector="Copy URL",
Expand Down Expand Up @@ -194,7 +194,10 @@ def is_new_connection_window_visible():
def is_credential_window_visible():
visible = False
try:
squish.waitForObject(AccountConnectionWizard.OAUTH_CREDENTIAL_PAGE)
app().find_element(
AccountConnectionWizard.OAUTH_CREDENTIAL_PAGE.by,
AccountConnectionWizard.OAUTH_CREDENTIAL_PAGE.selector
Comment on lines +197 to +199
Copy link
Copy Markdown
Contributor

@saw-jan saw-jan May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
app().find_element(
AccountConnectionWizard.OAUTH_CREDENTIAL_PAGE.by,
AccountConnectionWizard.OAUTH_CREDENTIAL_PAGE.selector
app().find_element(
AccountConnectionWizard.OAUTH_CREDENTIAL_PAGE.by,
AccountConnectionWizard.OAUTH_CREDENTIAL_PAGE.selector

)
visible = True
Comment on lines +197 to 201
Copy link
Copy Markdown
Contributor

@saw-jan saw-jan May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
app().find_element(
AccountConnectionWizard.OAUTH_CREDENTIAL_PAGE.by,
AccountConnectionWizard.OAUTH_CREDENTIAL_PAGE.selector
)
visible = True
visible= app().find_element(
AccountConnectionWizard.OAUTH_CREDENTIAL_PAGE.by,
AccountConnectionWizard.OAUTH_CREDENTIAL_PAGE.selector
).is_displayed()

except:
pass
Expand Down
13 changes: 4 additions & 9 deletions test/gui/steps/account_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,9 @@ def step(context):
AccountConnectionWizard.accept_certificate()


@When('the user adds the server "|any|"')
def step(context, server):
server_url = substitute_inline_codes(server)
@When('the user adds the server "{server_url}"')
def step(context, server_url):
server_url = substitute_inline_codes(server_url)
AccountConnectionWizard.add_server(server_url)


Expand All @@ -193,12 +193,7 @@ def step(context):

@Then('credentials wizard should be visible')
def step(context):
test.compare(
AccountConnectionWizard.is_credential_window_visible(),
True,
'Credentials wizard is visible',
)

AccountConnectionWizard.is_credential_window_visible()
Copy link
Copy Markdown
Contributor

@saw-jan saw-jan May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check true with ensure


@When('the user selects download everything option in advanced section')
def step(context):
Expand Down
Loading