test(GUI): enable account test#920
Closed
Asmitapaudel wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Asmitapaudel <asmeetapdl@gmail.com>
prashant-gurung899
requested review from
anon-pradip,
prashant-gurung899 and
saw-jan
saw-jan
reviewed
May 28, 2026
| ) | ||
| CHOOSE_FOLDER_BUTTON = SimpleNamespace(by=By.NAME, selector="Choose") | ||
| OAUTH_CREDENTIAL_PAGE = SimpleNamespace(by=None, selector=None) | ||
| OAUTH_CREDENTIAL_PAGE = SimpleNamespace(by=By.XPATH, selector="//label[@name='Log in with your web browser']") |
Contributor
There was a problem hiding this comment.
Suggested change
| OAUTH_CREDENTIAL_PAGE = SimpleNamespace(by=By.XPATH, selector="//label[@name='Log in with your web browser']") | |
| LOGIN_DIALOG = SimpleNamespace(by=By.XPATH, selector="//label[@name='Log in with your web browser']") |
Comment on lines
+197
to
+199
| app().find_element( | ||
| AccountConnectionWizard.OAUTH_CREDENTIAL_PAGE.by, | ||
| AccountConnectionWizard.OAUTH_CREDENTIAL_PAGE.selector |
Contributor
There was a problem hiding this comment.
Suggested change
| app().find_element( | |
| AccountConnectionWizard.OAUTH_CREDENTIAL_PAGE.by, | |
| AccountConnectionWizard.OAUTH_CREDENTIAL_PAGE.selector | |
| app().find_element( | |
| AccountConnectionWizard.OAUTH_CREDENTIAL_PAGE.by, | |
| AccountConnectionWizard.OAUTH_CREDENTIAL_PAGE.selector |
Comment on lines
+197
to
201
| app().find_element( | ||
| AccountConnectionWizard.OAUTH_CREDENTIAL_PAGE.by, | ||
| AccountConnectionWizard.OAUTH_CREDENTIAL_PAGE.selector | ||
| ) | ||
| visible = True |
Contributor
There was a problem hiding this comment.
Suggested change
| app().find_element( | |
| AccountConnectionWizard.OAUTH_CREDENTIAL_PAGE.by, | |
| AccountConnectionWizard.OAUTH_CREDENTIAL_PAGE.selector | |
| ) | |
| visible = True | |
| visible= app().find_element( | |
| AccountConnectionWizard.OAUTH_CREDENTIAL_PAGE.by, | |
| AccountConnectionWizard.OAUTH_CREDENTIAL_PAGE.selector | |
| ).is_displayed() |
| 'Credentials wizard is visible', | ||
| ) | ||
|
|
||
| AccountConnectionWizard.is_credential_window_visible() |
| And "Alice" account should be added | ||
|
|
||
|
|
||
| @smoke |
Contributor
There was a problem hiding this comment.
this is not a smoke test. Now, the workflow should be:
- skip all the tests that are not tagged
@smoke - fix and enable skipped tests
- in CI, run tests that are not marked
@skip
Suggested change
| @smoke |
Author
|
PR with clean branch name and clean changes is here: #921. So closing this one. |
Contributor
hmm, that was not necessary though. Anyways 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: #861
This PR enables the following account test: