Repository navigation
build(deps): refresh compatible workspace and CodeQL dependencies - #127
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: blocked before merge. Reviewed October 7, 2026, 3:46 PM ET / 19:46 UTC (Revision 3). ClawSweeper reviewWhat this changesRefreshes workspace libraries, development tools, and pinned CodeQL actions while aligning the Better Auth schema generator with its runtime. Merge readiness⛔ Blocked before merge - 3 items remain This consolidation remains useful and is absent from pinned main. The unchanged head still leaves the earlier authentication upgrade concerns unresolved; passing CI does not establish compatibility with existing authentication state. Priority: P2 Review scores
Verification
How this fits togetherWorkspace dependencies support Krillswitch’s dashboard, Cloudflare Worker, and development tooling. Better Auth receives GitHub sign-in callbacks and D1 authentication records, then supplies sessions used by management authorization; public flag evaluation remains separate. flowchart TD
A[Workspace dependency pins] --> B[Dashboard and Worker builds]
C[GitHub sign-in callback] --> D[Worker authentication]
E[D1 accounts and verification state] --> D
D --> F[Session and role checks]
F --> G[Management API]
H[SDK evaluation requests] --> B
Before merge
Agent review detailsSecurityNone. Review metrics
Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Retain the security update with verified existing-state compatibility and a clear deployment guide explaining coordinated cutover and restarting interrupted sign-ins. Do we have a high-confidence way to reproduce the issue? Yes, source provides a high-confidence path for the upgrade interruption: start GitHub sign-in under 1.6.33, then process its callback under 1.7.7, whose database lookup requires the new state prefix. This review did not execute that scenario. Is this the best way to solve the issue? Yes, consolidating the compatible updates and aligning the auth generator is a focused approach. Preserve the upstream security boundary and address its upgrade implications rather than restoring acceptance of legacy state. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 7be7204292c9. LabelsLabel changes: No label changes. Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
History |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: build(deps): refresh compatible workspace and CodeQL dependencies This is item 1/1 in the current shard. Shard 0/1. This temporary status tracks the active review worker. The completed review will appear in the durable ClawSweeper review comment. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
What Problem This Solves
Compatible dependency updates were spread across three bot PRs. This consolidates #123, #125, and #126 into one update and keeps the Better Auth schema generator on the same version as the runtime.
User Impact
Developers and operators get compatible library and tooling updates. The Node.js floor, package versions, security overrides, and two-day dependency cooldown are preserved.
Why This Change Was Made
Updates include Better Auth 1.7.7, Hono 4.13.12, TanStack Query 5.104.1, Biome 2.5.15, Vite 8.3.2, Cloudflare's Vitest plugin 1.3.6, Workers types, Wrangler 4.147.0, Node types, and the CodeQL 4.38.2 pin. The Node.js floor, package versions, security overrides, and two-day dependency cooldown are preserved.
Vitest 5 (#118) was closed because the current Cloudflare plugin requires Vitest 4 and the proposed upgrade fails to start the Worker suite. jsdom 30 (#117) was closed because its Node.js requirement excludes the declared 22.22.0 floor. Neither major is included.
Evidence
Validation passed on one AWS Crabbox lease with Node 24.19.0 and pnpm 11.28.0: frozen install, lint, typecheck, all 276 tests (6 script, 37 core, 33 React, 72 CLI, 128 Worker), dashboard/demo/CLI builds, docs build, and packed SDK verification. The lockfile was generated by pnpm and passed its supply-chain policy checks. Local actionlint and independent Codex review through P2 passed. Existing CSS warnings, synthetic test-secret warnings, and non-failing Worker DNS diagnostics remain.
The first remote setup attempt failed because Corepack could not write global shims; using a task-owned shim directory resolved it. No application gate was skipped. Exact-head CI and CodeQL passed at
03b8715678352deef9e1d4919b0ad30859d2fb3b. This PR awaits the required code-owner approval from the requested reviewers.