feat(slides): add native table creation#834
Conversation
|
Codex review: passed. Reviewed June 18, 2026, 1:08 AM ET / 05:08 UTC. Summary Reproducibility: not applicable. as a bug reproduction for this PR. Source inspection confirms the preexisting main-branch gap, while merge readiness depends on live provider proof of the new behavior. Review metrics: 2 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land only after redacted live Google Slides proof confirms table creation and cell text insertion, and either make the linked issue explicitly v1-complete or leave/open a follow-up for the remaining table operations. Do we have a high-confidence way to reproduce the issue? Not applicable as a bug reproduction for this PR. Source inspection confirms the preexisting main-branch gap, while merge readiness depends on live provider proof of the new behavior. Is this the best way to solve the issue? Mostly yes. The code path is a narrow native Slides v1 that follows nearby command patterns, but the best merge path still needs live proof and a maintainer decision on linked issue scope. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 7712dc6f6e25. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
@clawsweeper autofix Resolve the current merge conflict against latest main after #836 landed. Preserve the focused native Slides table implementation, integrate the current Slides command registry, regenerate command docs from the resolved tree, run focused and full validation, and keep this autogenerated PR manual-merge only. |
|
🦞🧹
This is fix-only; I will not merge this PR. Re-review progress:
|
|
🦞🔧 Repair: kept the fix on this contributor branch instead of opening a replacement PR. Current state: exact-head review queued immediately; GitHub checks and the review verdict gate final merge. Automerge progress:
|
b873f85 to
6ab3074
Compare
|
@clawsweeper stop Maintainer is handling this generated PR sequentially with design review, live provider proof, full CI, and autoreview. Stop active autofix/re-review automation and leave the branch stable for the maintainer rewrite. |
|
🦞✅ I added |
|
@clawsweeper autofix Accepted review finding: this table branch is based before #835 and would remove its style-text/link/bullets registrations and explicit replace-text scope safety if landed. Rebase onto current main, preserve all newly landed text-edit behavior and docs, resolve only overlapping Slides registry/generated-doc changes, run Slides/full validation, and keep this autogenerated PR manual-merge only. Do not edit CHANGELOG.md. |
|
🦞👀 Command router queued. I will update this comment with the next step. |
|
ClawSweeper 🐠 automerge status No new branch changes from this pass. ClawSweeper left the branch untouched instead of making a noisy edit. Executor outcome: source PR #834 is paused by clawsweeper:human-review; refusing to mutate the PR branch. Worker actions:
This pass stayed observational only. No branch push, replacement, merge, or re-review was started. fish notes: reasoning high. Automerge progress:
|
Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
6ab3074 to
3e0e1da
Compare
|
ClawSweeper 🐠 automerge status This repair pass finished without changing the PR. ClawSweeper checked the branch and found no safe patch to push this time. Executor outcome: source PR branch changed while the repair worker was preparing its push; requeue against the latest head. Worker actions:
Nothing moved downstream from this pass: no branch update, replacement PR, merge, or re-review. fish notes: reasoning high. Automerge progress:
|
|
@clawsweeper autofix Accepted review finding: remove the CHANGELOG.md entry from this contributor/generated PR. The source job and maintainer instruction explicitly keep gogcli release notes release-owned; preserve the release-note text and contributor credit in the PR body/commit history. Keep the current clean rebase and table implementation unchanged, rerun validation, and leave the PR manual-merge only. |
|
@clawsweeper autofix Accepted code finding: cell-targeted |
|
🦞👀 Command router queued. I will update this comment with the next step. |
|
🦞🔧 Repair: kept the fix on this contributor branch instead of opening a replacement PR. Current state: exact-head review queued immediately; GitHub checks and the review verdict gate final merge. Automerge progress:
|
|
@clawsweeper stop Maintainer is handling this generated PR sequentially with design review, live provider proof, full CI, and autoreview. Stop active autofix/re-review automation and leave the branch stable for the maintainer rewrite. |
|
🦞✅ I added |
98a9916 to
3e0e1da
Compare
|
🦞🔧 Repair: kept the fix on this contributor branch instead of opening a replacement PR. Current state: exact-head review queued immediately; GitHub checks and the review verdict gate final merge. Automerge progress:
|
|
@clawsweeper autofix Accepted review finding on repaired head e513dbc: table-cell |
|
🦞🔧 Repair: kept the fix on this contributor branch instead of opening a replacement PR. Current state: exact-head review queued immediately; GitHub checks and the review verdict gate final merge. Automerge progress:
|
Summary
gog slides table createfor native tables with rows, columns, and an optional stable object IDgog slides insert-textwith paired zero-based--row/--colcell targeting and atomic--replaceThis is the intentionally narrow first slice of #824. The issue remains open for row/column insertion and deletion, merge/unmerge, sizing, borders, and cell styling.
Design
Google's current Slides table recipe states that table creation ignores supplied size and transform fields. Live provider read-back confirmed this behavior, so the command omits misleading geometry flags and lets Slides choose initial placement and size.
Validation
go test ./internal/cmd -run 'TestSlides(Table|InsertText)'make ciCredit
Thanks @sebsnyk for #824 and the requested command shape.