feat(slides): add native slide structure commands#833
Conversation
|
Codex review: passed. Reviewed June 18, 2026, 2:48 AM ET / 06:48 UTC. Summary Reproducibility: not applicable. for this feature PR. The linked issue has source-level evidence for the missing command surface; this review checks whether the proposed implementation is merge-ready. Review metrics: 2 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Post redacted live deck proof, avoid closing the broader issue unless the remaining element work is separately tracked, then land this focused slide-structure slice if maintainers accept the command shape. Do we have a high-confidence way to reproduce the issue? Not applicable for this feature PR. The linked issue has source-level evidence for the missing command surface; this review checks whether the proposed implementation is merge-ready. Is this the best way to solve the issue? Yes for the focused first slice: small batchUpdate-backed commands are the maintainable path for native slide create, duplicate, and move. It is not merge-ready without live deck proof and a maintainer decision on the broader linked issue closure. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against fa3fa1638b5a. Label changesLabel justifications:
Evidence reviewedAcceptance criteria:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
ClawSweeper 🐠 automerge status ClawSweeper took another look; no safe branch change was available on this pass. Executor outcome: source PR #833 is paused by clawsweeper:human-review; refusing to mutate the PR branch. Worker actions:
Nothing moved downstream from this pass: no branch update, replacement PR, merge, or re-review. fish notes: reasoning high. Automerge progress:
|
|
@clawsweeper autofix Resolve the current merge conflict against latest main after #836 landed. Preserve the focused native slide-structure implementation, integrate the current Slides command registry, regenerate command docs from the resolved tree, run focused and full validation, and keep this autogenerated PR manual-merge only. |
|
🦞🔧
This is fix-only; I will not merge this PR. |
3c3100f to
c1e3adf
Compare
|
@clawsweeper stop Maintainer is handling this generated PR sequentially with design review, live provider proof, full CI, and autoreview. Stop active autofix/re-review automation and leave the branch stable for the maintainer rewrite. |
|
🦞✅ I added |
|
@clawsweeper autofix Main advanced again when #835 landed. Rebase this structural-slides PR onto current main, preserve all newly landed style-text/link/bullets/replace-text behavior and docs, resolve only overlapping Slides registry/generated-doc changes, run Slides/full validation, and keep this autogenerated PR manual-merge only. Do not edit CHANGELOG.md. |
|
🦞👀 Command router queued. I will update this comment with the next step. |
|
@clawsweeper autofix Main advanced when #837 landed. The remaining conflict is generated command documentation ( |
Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
c1e3adf to
cc4dabe
Compare
|
Landed as Maintainer validation:
|
Summary
gog slides new-slidefor native editable slides, defaulting to blank and supporting validated predefined layouts or exact theme--layout-idvaluesgog slides duplicate-slide, with optional atomic--to-indexpositioninggog slides move-slidewith explicit zero-based--to-indexThis is the intentionally narrow slide-level first slice of #826. The issue remains open for the broader element create/transform/style/group/z-order/alt-text subtree.
Validation
go test ./internal/cmd -run 'TestSlides(NewSlide|DuplicateSlide|MoveSlide)'make ciTITLE_AND_BODY, and an exact theme layout ID fromslides info --jsonlist-slides --jsonorder read-back after each phaseCredit
Thanks @sebsnyk for #826 and the requested command shape.