Repository navigation
build(deps): refresh Go dependencies and patched toolchains - #273
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesThis PR updates preferred Go toolchains to 1.27.2, refreshes dependencies, and runs analyzers through the pinned module graph. Example: Build Discrawl from source with automatic Go toolchain selection.
Review scores
ProductKind: Maintenance · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: this maintainer-authored security maintenance change is absent from current main, preserves existing contracts, and has no actionable findings. Priority: P2 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherModule declarations and container pins select build inputs; Makefile and CI commands use them to produce CLI binaries, language helpers, and analysis results. flowchart TD
A[Module and image pins] --> B[Go toolchain]
B --> C[CLI and helper builds]
A --> D[Pinned analyzer graph]
D --> E[Local and CI checks]
C --> F[Release artifacts]
Technical reviewBest possible solution: Land the compatible compiler and dependency refresh through the existing release process. Do we have a high-confidence way to reproduce the issue? The author reports nine reachable findings on Go 1.27.1; current-main pins confirm that compiler preference, but this review did not independently run the vulnerability reproduction. Is this the best way to solve the issue? Updating the preferred compiler and sharing a compatible analyzer dependency graph addresses the reported problems while preserving minimum versions and existing checks. AGENTS.md: found but not applied because it conflicted with ClawSweeper's review contract. Codex review notes: model internal, reasoning medium; reviewed against b30bf685b554. Provenance checked
TestingProof path: shipped entry point. SecurityNone. EvidenceWhat I checked:
Likely related people:
LabelsLabel changes: No label changes. Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment HistoryReviewed October 10, 2026, 5:57 AM ET / 09:57 UTC (Revision 3). |
What Problem This Solves
Builds using Go 1.27.1 expose nine reachable standard-library vulnerabilities reported by
govulncheck ./....User Impact
Use Go 1.27.2 for the CLI, Docker build and optional language-helper builds. The documented minimum remains Go 1.27.0 for the CLI and Go 1.26 for the helpers. No database migration or release is included.
Why This Change Was Made
Refresh the preferred toolchains and verified Docker image pins together, along with the available patch/minor updates to
x/sys,x/text,x/crypto, terminal ANSI handling and character widths. Keep installation documentation and the Unreleased changelog aligned.Standalone Staticcheck and Gosec could not read the new compiler export format. Register the existing analyzers as Go tools so they share the compatible, pinned
x/toolsreader through the module graph. Preserve all analyzer checks and exclusions, and align local and CI commands.Evidence
The unchanged main revision reproduced nine reachable standard-library findings under Go 1.27.1. The updated candidate reports zero reachable vulnerabilities. On AWS Linux,
make checkpassed, including lint, race tests, 85.5% coverage (85% required), CLI smoke and six-platform snapshot builds. Source-reconciliation tests and all 15 cloud-publisher/documentation tests passed. All three language helpers passed module verification, vulnerability scans and tests under Go 1.27.2.Independent Codex autoreview passed the complete staged candidate with no actionable P0–P3 findings. Exact-head GitHub Actions passed at
955bf6af76e9b3f2ae3e4507d9f4ad63743ab99a: https://github.com/openclaw/discrawl/actions/runs/38042737788 (including native Windows/macOS and helper jobs); Docker, CodeQL, secret scanning and repair-helper synthetic validation also passed.