Repository navigation
build(deps): patch gRPC and refresh workflow actions - #276
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesThis PR updates gRPC to v1.83.2, setup-node to v7.1.0, and the TruffleHog action reference to v3.99.0. Example: Documentation CI prepares Node 26.
Review scores
ProductKind: Maintenance · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep this PR open: main still lacks these useful dependency updates, and the reviewed diff introduces no actionable correctness or security defect. Priority: P3 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherGitHub workflows consume pinned actions to build documentation, prepare cloud publication, and scan secrets; the Go module graph supplies dependencies to the Discrawl CLI. flowchart TD
A[Workflow events] --> B[Pinned actions]
B --> C[Documentation builds]
B --> D[Conditional cloud publication]
B --> E[Secret scan results]
F[Go module graph] --> G[Discrawl CLI]
Technical reviewBest possible solution: Land the verified dependency updates while preserving the existing runtime selections and workflow boundaries. Do we have a high-confidence way to reproduce the issue? The outdated references are directly verified on main; the upstream advisory establishes the affected dependency version without establishing an exploitable Discrawl server path. Is this the best way to solve the issue? Updating the existing pinned references is a narrow solution that preserves prior maintenance intent and avoids introducing another dependency-management path. AGENTS.md: found but not applied because it conflicted with ClawSweeper's review contract. Codex review notes: model internal, reasoning medium; reviewed against ee0683bcfda6. Provenance checked
TestingProof path: unit tests only. SecurityNone. EvidenceWhat I checked:
Likely related people:
Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. LabelsLabel changes: No label changes. Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment HistoryReview history (1 earlier review cycle)
Reviewed October 11, 2026, 5:08 AM ET / 09:08 UTC (Revision 2). |
Refresh setup-node to v7.1.0 across CI, docs, and the existing publisher, and TruffleHog to v3.99.0. This consolidates the compatible minor updates from #274 and #275 while retaining the existing Node versions, scan options, and workflow triggers.
Also update transitive gRPC from v1.83.1 to v1.83.2, the patched version for GHSA-2v4p-qf9q-27wj (xDS server denial of service). Preserve the existing Go minimum and Go 1.27.2 toolchain. Add Unreleased entries and retain Dependabot credit.
Validation: independent Codex review is clean through P3 for the complete diff. AWS validation passed
make check(race tests, 85.5% coverage, analyzers, zero reachable vulnerabilities, CLI smoke, six-platform unpublished snapshots), all 15 Node tests, docs generation, and source-reconciliation tests. Exact-head CI: https://github.com/openclaw/discrawl/actions/runs/38127024605. No release, version bump, or manual deployment.