Skip to content

[WIP] Pre-Commit: Clang-Format CXX Endings #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[WIP] Pre-Commit: Clang-Format CXX Endings #1228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/clang-format/clang-format.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ else
# received no arguments, find files on our own
find include/ src/ test/ examples/ \
-regextype egrep \
-type f -regex '.*\.(hpp|cpp|hpp\.in)$' \
-type f -regex '.*\.(c|cpp|cxx|h|hpp|tpp)(\.in)?$' \
| xargs clang-format-13 -i
fi
2 changes: 2 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ repos:
rev: v13.0.1
hooks:
- id: clang-format
types: [file]
files: '.*\.(c|cpp|cxx|h|hpp|tpp)(\.in)?$'
Copy link
Member Author

@ax3l ax3l Mar 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not yet seem to work 🤔
Should be python regex: https://pre-commit.com/#regular-expressions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this works, I to also need to add .json here as we use this for json formatting as well #1222


# Autoremoves unused Python imports
- repo: https://github.com/hadialqattan/pycln
Expand Down