Skip to content

Conversation

`identify` used to detect our files does not catch
all our file endings.
hooks:
- id: clang-format
types: [file]
files: '.*\.(c|cpp|cxx|h|hpp|tpp)(\.in)?$'
Copy link
Member Author

@ax3l ax3l Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not yet seem to work 🤔
Should be python regex: https://pre-commit.com/#regular-expressions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this works, I to also need to add .json here as we use this for json formatting as well #1222

@franzpoeschel
Copy link
Contributor

You were right, .tpp files are not yet considered by the manual script https://github.com/openPMD/openPMD-api/blob/dev/.github/workflows/clang-format/clang-format.sh

@franzpoeschel
Copy link
Contributor

Otherwise, this PR has been mainly obsoleted by #1403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants