forked from openedx/openedx-platform
-
Notifications
You must be signed in to change notification settings - Fork 7
feat: return unit upstreamInfo and disallow edits to units in courses that are sourced from a library [FC-0083] #773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pomegranited
merged 7 commits into
navin/fal-4077/link-unit
from
chris/FAL-4075-get-unit-updstream
Apr 24, 2025
Merged
feat: return unit upstreamInfo and disallow edits to units in courses that are sourced from a library [FC-0083] #773
pomegranited
merged 7 commits into
navin/fal-4077/link-unit
from
chris/FAL-4075-get-unit-updstream
Apr 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d9e6e16 to
fe316a1
Compare
d32dcc7 to
d0f248b
Compare
d0f248b to
945025a
Compare
…o chris/FAL-4075-get-unit-updstream
These container events take LibraryContainerLocators, not strings.
863c696 to
b248df6
Compare
6f286ad to
45e9a34
Compare
…o chris/FAL-4075-get-unit-updstream
…ary [FC-0083] (#774) Disallows edits to library-sourced units in the contentstore preview view and XBlock wrapper. Co-authored-by: Rômulo Penido <romulo.penido@gmail.com>
ChrisChV
added a commit
that referenced
this pull request
Apr 24, 2025
) * feat: library unit sync * feat: create component link only for component xblocks * feat: container link model * feat: update downstream api views * feat: delete extra components in container on sync (not working) * fix: duplicate definitions of LibraryXBlockMetadata * test: add a new integration test suite for syncing * feat: partially implement container+child syncing * fix: blockserializer wasn't always serializing all HTML block fields * feat: handle reorder, addition and deletion of components in sync Updates children components of unit in course based on upstream unit, deletes removed component, adds new ones and updates order as per upstream. * feat: return unit upstreamInfo and disallow edits to units in courses that are sourced from a library (#773) * feat: Add upstream_info to unit * feat: disallow edits to units in courses that are sourced from a library (#774) --------- Co-authored-by: Jillian Vogel <jill@opencraft.com> Co-authored-by: Rômulo Penido <romulo.penido@gmail.com> * docs: capitalization of XBlock Co-authored-by: David Ormsbee <dave@axim.org> * refactor: (minor) change python property name to reflect type better * fix: lots of "Tried to inspect a missing...upstream link" warnings when viewing a unit in Studio * docs: mention potential REST API for future refactor * fix: check if upstream actually exists before making unit read-only * chore: fix camel-case var * fix: test failure when mocked XBlock doesn't have UpstreamSyncMixin --------- Co-authored-by: Braden MacDonald <braden@opencraft.com> Co-authored-by: Chris Chávez <xnpiochv@gmail.com> Co-authored-by: Jillian Vogel <jill@opencraft.com> Co-authored-by: Rômulo Penido <romulo.penido@gmail.com> Co-authored-by: Braden MacDonald <mail@bradenm.com> Co-authored-by: David Ormsbee <dave@axim.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
xblock_infowithupstream_infoSupporting information
Testing instructions
Other information
N/A