Double Edit Buttons on Unit Course Authoring Page

[sdaitzman]

Seeing this on the Teak and Tagging sandboxes.

[bradenmacdonald]

@navinkarkera I think this was introduced by openedx/openedx-platform#36553 but it's hard to believe that all components on master have had double edit buttons for a month and nobody complained?

In any case, it's possible to fix by deleting these lines, but I'm not sure if that's going to cause other problems.

[navinkarkera]

but it's hard to believe that all components on master have had double edit buttons for a month and nobody complained?

@bradenmacdonald It is probably due to some weird bug which hides edit button, atleast I see something like this in my local.

@ChrisChV Seems like we replaced elif by if statement in open-craft/openedx-platform#773, was there some reason to do it and will it cause issues if we remove it?

[ChrisChV]

@ChrisChV Seems like we replaced elif by if statement in open-craft/openedx-platform#773, was there some reason to do it and will it cause issues if we remove it?

Hi @navinkarkera, I think @pomegranited and @rpenido added that change in open-craft/openedx-platform@57b2205 to disable editing on units. I don't see any problem in deleting it, but the best answer would be from @pomegranited and @rpenido 😄

[rpenido]

I don't think this change was intended (probably introduced on a merge).
We must revert the elif -> if change and remove one indent.
The elif corresponded to the if can_edit: condition.
This should fix the double edit buttons.

It is probably due to some weird bug which hides edit button, atleast I see something like this in my local.

This unit was from a library? I think the double-edit only happens on units created on courses.

Note:
show_inline = xblock.has_children and not xblock_url
I don't know when this condition is met, but in that case, the second edit will be shown even if the unit is from a library (can_edit = false).

Edit: Since I was on the issue, I created a PR here: openedx/openedx-platform#36770

[rpenido]

Backport PR here: openedx/openedx-platform#36780 CC @pomegranited

[pomegranited]

@jmakowski1123 @sdaitzman @edschema This is ready for AC testing on the sandbox

[edschema]

Looks good! I'll look back on the month of double edit buttons fondly. 😅

[jmakowski1123]

I'm getting this error message whenever I try to open a unit page from the course?

[bradenmacdonald]

@jmakowski1123 It's a known error, similar to #2007 and should be fixed by #1867 but that PR has been stalled for a couple weeks - it needs some more test coverage and a review. Could you either help get that expedited or we can do a more targeted fix (since that PR does a lot more than just fix this bug)?