Skip to content

Updates to align with AccessAPI changes on flow-go master #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 29, 2023

Conversation

peterargue
Copy link
Contributor

@peterargue peterargue commented Nov 28, 2023

This PR pulls in changes from 3 other PRs:

This aligns the AccessAPI with the latest changes on master

Note: this also updates the go version since the flow-go repo now uses features only available in v1.20

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (f1e6dd6) 50.75% compared to head (02670e7) 50.51%.

Files Patch % Lines
adapters/access.go 0.00% 8 Missing ⚠️
adapters/sdk.go 0.00% 8 Missing ⚠️
server/access/streamBackend.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #518      +/-   ##
==========================================
- Coverage   50.75%   50.51%   -0.24%     
==========================================
  Files          30       30              
  Lines        3933     3951      +18     
==========================================
  Hits         1996     1996              
- Misses       1784     1802      +18     
  Partials      153      153              
Flag Coverage Δ
unittests 50.51% <0.00%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterargue peterargue force-pushed the petera/access-api-updates branch from 02670e7 to 78514ea Compare November 29, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants