[Access] Get protocol snapshot by block id and block height #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriiDiachuk
requested review from
devbugging,
turbolent,
janezpodhostnik,
bluesign and
chasefleming
as code owners
|
thanks for adding this @AndriiDiachuk |
bluesign
approved these changes
Nov 9, 2023
turbolent
reviewed
Nov 9, 2023
go.mod
Outdated
Comment on lines
195
to
197
| replace github.com/onflow/flow-go v0.32.3 => github.com/Guitarheroua/flow-go v0.0.0-20231024184136-247768e776f7 | ||
| replace github.com/onflow/flow-go v0.32.3 => github.com/AndriiDiachuk/flow-go v0.0.0-20231108171341-18d79032dc5d | ||
|
|
||
| replace github.com/onflow/flow/protobuf/go/flow v0.3.2-0.20231018182244-e72527c55c63 => github.com/AndriiDiachuk/flow/protobuf/go/flow v0.0.0-20231101114612-70243c40d6a7 |
There was a problem hiding this comment.
Would it be possible to wait with this PR until the upstream changes have landed?
It looks like already previously the dependency was changed to another repo, and then it wasn't updated back to the main repo (onflow/flow-go)
There was a problem hiding this comment.
I agree. Also @turbolent #503 (review)
There was a problem hiding this comment.
these should be merged now. @AndriiDiachuk can you update?
devbugging
suggested changes
Nov 9, 2023
|
these changes were included in #518 |
Thanks a lot. |
…AndriiDiachuk/4869-get-protocol-snapshot-from-any-block-endpoint
AndriiDiachuk
deleted the
AndriiDiachuk/4869-get-protocol-snapshot-from-any-block-endpoint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onflow/flow-go#4869
This pull request implements two missing methods
GetProtocolStateSnapshotByBlockID, GetProtocolStateSnapshotByHeightfrom Access API interface.