fix(gateway): stop actors on session delete#1220
Open
ymote wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Current-main validation refresh for #1219. Scope validated:
Commands run:
Results:
Current-main blocker found:
Issue fit:
Remaining gap:
|
a88f59a to
a66a2dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/deletehandling into the existing session-delete event channel used to stop in-memory session actors.Closes #1219
Current-main refresh
main/origin/main4adbe05fff212cb85d1f0a6d6225da0713446016.a66a2dd851659989c203f7c981ce2364e7b09dbe./private/tmp/octos-1220-current.f8pao4/octos.rustc 1.95.0;cargo 1.95.0.Local validation
git diff --check origin/main...HEADpassed.cargo fmt --all -- --checkpassed.rustfmt --check crates/octos-cli/src/commands/gateway/gateway_runtime.rs crates/octos-cli/src/gateway_dispatcher.rspassed.typos crates/octos-cli/src/commands/gateway/gateway_runtime.rs crates/octos-cli/src/gateway_dispatcher.rspassed.CARGO_TARGET_DIR=/private/tmp/octos-1220-current-4adbe-target-cli CARGO_INCREMENTAL=0 CARGO_PROFILE_DEV_DEBUG=0 cargo test -p octos-cli gateway_dispatcher::tests::should_signal_actor_stop -- --nocapturepassed: 2/2 matching tests.CARGO_TARGET_DIR=/private/tmp/octos-1220-current-4adbe-target-cli CARGO_INCREMENTAL=0 CARGO_PROFILE_DEV_DEBUG=0 cargo test -p octos-cli gateway_dispatcher::tests::should_delete -- --nocapturepassed: 3/3 matching tests.CARGO_TARGET_DIR=/private/tmp/octos-1220-current-4adbe-target-cli CARGO_INCREMENTAL=0 CARGO_PROFILE_DEV_DEBUG=0 cargo test -p octos-cli gateway_dispatcher::tests -- --nocapturepassed: 34/34 gateway dispatcher tests.CARGO_TARGET_DIR=/private/tmp/octos-1220-current-4adbe-target-cli CARGO_INCREMENTAL=0 CARGO_PROFILE_DEV_DEBUG=0 cargo clippy --workspace --all-targets -- -D warningspassed.git ls-files --others --exclude-standardwas empty in the isolated checkout.CI / merge status
a66a2dd851659989c203f7c981ce2364e7b09dbe:check,check-matrix,dashboard,swarm-app,test-octos-cli,test-octos-agent (lib),test-octos-agent (integration),typos, and author-email all passed.MERGEABLEbut remains branch-protection blocked by required review (REVIEW_REQUIRED).