Skip to content

Stop gateway actors after slash delete#1282

Closed
ymote wants to merge 1 commit into
mainfrom
codex/issue-1219-delete-cancels-actor
Closed

Stop gateway actors after slash delete#1282
ymote wants to merge 1 commit into
mainfrom
codex/issue-1219-delete-cancels-actor

Conversation

@ymote

@ymote ymote commented May 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • wire gateway slash-command deletion into the existing session-delete actor removal channel
  • notify the runtime only after SessionManager::clear succeeds
  • add dispatcher regressions for named deletion and current-topic deletion notifications

Closes #1219

Validation

  • CARGO_TARGET_DIR=/private/tmp/octos-1219-target cargo test -p octos-cli --features api should_notify_runtime_when -- --nocapture
  • CARGO_TARGET_DIR=/private/tmp/octos-1219-target cargo test -p octos-cli --features api gateway_dispatcher::tests::should_delete -- --nocapture
  • CARGO_TARGET_DIR=/private/tmp/octos-1219-target cargo clippy -p octos-cli --features api --all-targets

Notes: clippy passed with existing warnings in untouched code.

@ymote

ymote commented May 25, 2026

Copy link
Copy Markdown
Contributor Author

Closing this as a duplicate of the earlier #1220, which already targets #1219 with the same gateway /delete actor-stop fix and validation. Keeping #1220 as the active review/merge vehicle avoids duplicate closure PRs for the same issue.

@ymote ymote closed this May 25, 2026
@ymote ymote deleted the codex/issue-1219-delete-cancels-actor branch June 2, 2026 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Gateway /delete fails to stop the in-memory session actor

1 participant