-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix MSys2 side-conditions for conf-packages, part 2/3 #28944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ing MSys2 installation
|
CI spotted a couple of things, confirming that MSys2 CI was a good idea to add! 😄 First off, This turns out to be due to too strict Secondly, Looking at https://packages.msys2.org/packages/mingw-w64-x86_64-ncurses As such, this is actually working as intended, telling us there is no such file. |
|
The MSys2 MinGW CI rerun is failing on
|
This is the promised second PR out of 3, that solves MSys2 side conditions, as announced in #28939.
TLDR: since opam.2.2 MSys uses
os = "win32"andos-distribution = "msys2"meaning that the MSys2 side-conditions forconf-packages are subtly wrong, see for example #28769 (review).This second PR combs over and corrects the following
conf-packages:- conf-gtksourceview3
- conf-libevent
- conf-libffi
- conf-liblz4
- conf-libpcre2-8
- conf-libpcre
- conf-libssl
- conf-ncurses