Skip to content

Conversation

@jmid
Copy link
Member

@jmid jmid commented Nov 21, 2025

This is the 3rd of 3 PRs fixing MSys2 conf-package side-conditions, following #28939 and #28944.

TLDR: since opam.2.2 MSys uses os = "win32" and os-distribution = "msys2" meaning that the MSys2 side-conditions for conf-packages can be subtly wrong.

This 3rd corrects the following conf-packages:
- conf-postgresql
- conf-rubberband
- conf-sdl2
- conf-sdl2-image
- conf-sdl2-mixer
- conf-sdl2-net
- conf-sdl2-ttf
- conf-sndfile
- conf-sqlite3
- conf-zlib
- conf-zstd

While going over conf-files I noticed conf-rubberband and conf-sndfile weren't pkgconf-testing the installed file (both are MSys2 only), so I added an explicit test to both of them.

@jmid
Copy link
Member Author

jmid commented Nov 21, 2025

I've added the latest two commits to please the linter:

  • conf-zstd was missing a conf flag
  • the added test in conf-sndfile was referring to, e.g., host-arch-x86_32:installed but missing a corresponding depends field

@mseri
Copy link
Member

mseri commented Nov 23, 2025

This should be all right to merge, what do you think?

@jmid
Copy link
Member Author

jmid commented Nov 23, 2025

I agree 👍

CI-wise there are

  • another ton of revdeps failures
  • conf-file issues to fix on Centos, OpenSuse, and macOS

Again, to avoid too much CI strain, we should address those failures in separate PRs.

@mseri mseri merged commit 96657e4 into ocaml:master Nov 23, 2025
3 of 4 checks passed
@jmid jmid deleted the conf-msys2-fixes-part3 branch November 23, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants