Fix MSys2 side-conditions for conf-packages, part 3/3 #28945
Merged
+32
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 3rd of 3 PRs fixing MSys2
conf-package side-conditions, following #28939 and #28944.TLDR: since opam.2.2 MSys uses
os = "win32"andos-distribution = "msys2"meaning that the MSys2 side-conditions forconf-packages can be subtly wrong.This 3rd corrects the following
conf-packages:- conf-postgresql
- conf-rubberband
- conf-sdl2
- conf-sdl2-image
- conf-sdl2-mixer
- conf-sdl2-net
- conf-sdl2-ttf
- conf-sndfile
- conf-sqlite3
- conf-zlib
- conf-zstd
While going over
conf-files I noticedconf-rubberbandandconf-sndfileweren'tpkgconf-testing the installed file (both are MSys2 only), so I added an explicit test to both of them.