Filter pending blocks as well as canonical #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boray
approved these changes
Mar 1, 2025
|
Re: changelog, we never actually release new versions of this... staketab just grab the commit and run it from source. I think it's a good idea to tag versions and keep a changelog. We will have to keep ourselves honest. |
|
Merging this now to solve a need for zknoid |
45930
added a commit
that referenced
this pull request
Mar 10, 2025
Follow on to #115 ..... This PR moves the query our of the recursive CTE and into the full chain union query. The height referenced in the recursive CTE is not usable as I was trying previously. Example screenshots from the old code: As you can see, it is possible to query the right event, but the height filter is not the expected number.   New code: As you see, the specific query now selects the correct actions. 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the block height filter to the pending blocks as well as canonical.
Currently, if a user filters for actions from blocks a to b, they will get those plus all actions that are in pending blocks, regardless of their block height.
We should filter the canonical and the pending chains so that users who make a specific request get only the data they asked for. In the default case, there is no difference since the last
nblocks will aways included the pending chain.OLD:
NEW:
