Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move pending blocks query out of recursive CTE #116

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

45930
Copy link
Contributor

@45930 45930 commented Mar 7, 2025

Follow on to #115 .....

This PR moves the query our of the recursive CTE and into the full chain union query. The height referenced in the recursive CTE is not usable as I was trying previously.

Example screenshots from the old code:

As you can see, it is possible to query the right event, but the height filter is not the expected number.

image

image

New code:

As you see, the specific query now selects the correct actions.

image

@45930 45930 requested a review from boray March 7, 2025 04:03
Copy link
Member

@boray boray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: We need to add tests to catch edge cases as discussed.

@45930 45930 merged commit 9565918 into main Mar 10, 2025
4 checks passed
@45930 45930 deleted the 2025-03-move-pending-query branch March 10, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants