VPN-4511: Add custom dns settings #4128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agentpietrucha
requested review from
dainius-nym,
fmtabbara,
mrkiwi,
pronebird,
tommyv1987 and
trojanfoe
1 task
mrkiwi
approved these changes
Dec 5, 2025
Contributor
|
At the moment Custom DNS changes can be applied without needing to reconnect. This may change shortly though. |
trojanfoe
requested changes
Dec 5, 2025
Contributor
trojanfoe
left a comment
trojanfoe
left a comment
There was a problem hiding this comment.
We need to discuss this further with Marc before it's merged.
pronebird
reviewed
Dec 5, 2025
Collaborator
pronebird
left a comment
pronebird
left a comment
There was a problem hiding this comment.
I think that custom DNS IPs should be editable even when custom DNS toggle is off. For that we could use "Edit" button. I don't think we need alert saying to apply changes.
Reviewable status: 0 of 36 files reviewed, all discussions resolved (waiting on @dainius-nym, @fmtabbara, and @tommyv1987)
mrkiwi
approved these changes
Dec 10, 2025
trojanfoe
approved these changes
Dec 11, 2025
Contributor
trojanfoe
left a comment
trojanfoe
left a comment
There was a problem hiding this comment.
Please update the change log and then merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
JIRA-VPN-4511
Description
Checklist:
Screenshots (optional, if UI related)
This change is