VPN-4511 allow custom dns #4123
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove legacy call to ConnectTunnel * Rename connect_v2 to connect * Update changelog * tauri: fix
Co-authored-by: NYM_bot <_@_>
Co-authored-by: NYM_bot <_@_> Co-authored-by: Karol Sawicki <[email protected]>
pronebird
reviewed
Dec 4, 2025
Collaborator
pronebird
left a comment
pronebird
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 78 files reviewed, 1 unresolved discussion (waiting on @agentpietrucha)
nym-vpn-core/crates/nym-vpnd/src/service/config/legacy.rs line 13 at r1 (raw file):
#[serde(rename_all = "snake_case")] pub(crate) struct VpnServiceConfig { pub(crate) entry_point: EntryPoint,
This looks like a rebase issue?
Collaborator
|
Please |
Contributor
Author
|
@pronebird I moved to a new PR due to time consuming conflicts here. #4128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
JIRA-VPN-4511
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Checklist:
Screenshots (optional, if UI related)
This change is