Skip to content

test: fix audit contract test isolation #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ngjunsiang merged 1 commit into from
Apr 10, 2026
Merged

test: fix audit contract test isolation #452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 32 additions & 25 deletions tests/contract/test_audit_traces.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,14 @@ class TestAuditHealthContract(unittest.TestCase):

@classmethod
def setUpClass(cls):
cls.manager = services.create_service_manager()
cls.manager = services.create_service_manager(shared=False)
cls.manager.setup()
# Note: audit_app is created as part of the ServiceManager setup
cls.app = cls.manager.audit_app

@classmethod
def tearDownClass(cls):
cls.manager.reset_test_data()
cls.manager.close()
import campus.storage.testing
campus.storage.testing.reset_test_storage()
Expand Down Expand Up @@ -62,7 +63,7 @@ class TestAuditTracesIngestContract(unittest.TestCase):

@classmethod
def setUpClass(cls):
cls.manager = services.create_service_manager()
cls.manager = services.create_service_manager(shared=False)
cls.manager.setup()
cls.app = cls.manager.audit_app

Expand All @@ -72,6 +73,7 @@ def setUpClass(cls):

@classmethod
def tearDownClass(cls):
cls.manager.reset_test_data()
cls.manager.close()
import campus.storage.testing
campus.storage.testing.reset_test_storage()
Expand Down Expand Up @@ -108,18 +110,18 @@ def _make_test_span(self, **overrides):
return span

def test_ingest_spans_requires_authentication(self):
"""POST /audit/v1/traces requires authentication."""
"""POST /audit/v1/traces/ requires authentication."""
response = self.client.post(
"/audit/v1/traces",
"/audit/v1/traces/",
json={"spans": [self._make_test_span()]}
)

self.assertEqual(response.status_code, 401)

def test_ingest_single_span_success(self):
"""POST /audit/v1/traces with single span returns 201."""
"""POST /audit/v1/traces/ with single span returns 201."""
response = self.client.post(
"/audit/v1/traces",
"/audit/v1/traces/",
json={"spans": [self._make_test_span()]},
headers=self.auth_headers
)
Expand All @@ -131,14 +133,14 @@ def test_ingest_single_span_success(self):
self.assertNotIn("failed", data)

def test_ingest_batch_spans_success(self):
"""POST /audit/v1/traces with multiple spans returns 201."""
"""POST /audit/v1/traces/ with multiple spans returns 201."""
spans = [
self._make_test_span(span_id=f"span{i}", trace_id=f"trace{i}")
for i in range(3)
]

response = self.client.post(
"/audit/v1/traces",
"/audit/v1/traces/",
json={"spans": spans},
headers=self.auth_headers
)
Expand All @@ -148,19 +150,19 @@ def test_ingest_batch_spans_success(self):
self.assertEqual(len(data["created"]), 3)

def test_ingest_missing_spans_field_returns_error(self):
"""POST /audit/v1/traces without 'spans' field returns 400."""
"""POST /audit/v1/traces/ without 'spans' field returns 400."""
response = self.client.post(
"/audit/v1/traces",
"/audit/v1/traces/",
json={},
headers=self.auth_headers
)

self.assertEqual(response.status_code, 400)

def test_ingest_invalid_span_returns_error(self):
"""POST /audit/v1/traces with invalid span data returns 400."""
"""POST /audit/v1/traces/ with invalid span data returns 400."""
response = self.client.post(
"/audit/v1/traces",
"/audit/v1/traces/",
json={"spans": [{"invalid": "data"}]},
headers=self.auth_headers
)
Expand All @@ -173,7 +175,7 @@ class TestAuditTracesListContract(unittest.TestCase):

@classmethod
def setUpClass(cls):
cls.manager = services.create_service_manager()
cls.manager = services.create_service_manager(shared=False)
cls.manager.setup()
cls.app = cls.manager.audit_app

Expand All @@ -183,6 +185,7 @@ def setUpClass(cls):

@classmethod
def tearDownClass(cls):
cls.manager.reset_test_data()
cls.manager.close()
import campus.storage.testing
campus.storage.testing.reset_test_storage()
Expand All @@ -192,15 +195,15 @@ def setUp(self):
self.auth_headers = get_basic_auth_headers(env.CLIENT_ID, env.CLIENT_SECRET)

def test_list_traces_requires_authentication(self):
"""GET /audit/v1/traces requires authentication."""
response = self.client.get("/audit/v1/traces")
"""GET /audit/v1/traces/ requires authentication."""
response = self.client.get("/audit/v1/traces/")

self.assertEqual(response.status_code, 401)

def test_list_traces_empty_returns_empty_list(self):
"""GET /audit/v1/traces with no traces returns empty list."""
"""GET /audit/v1/traces/ with no traces returns empty list."""
response = self.client.get(
"/audit/v1/traces",
"/audit/v1/traces/",
headers=self.auth_headers
)

Expand All @@ -210,7 +213,7 @@ def test_list_traces_empty_returns_empty_list(self):
self.assertIn("cursor", data)

def test_list_traces_returns_trace_summaries(self):
"""GET /audit/v1/traces returns trace summaries with cursor."""
"""GET /audit/v1/traces/ returns trace summaries with cursor."""
# First, ingest a span
from campus.audit.resources.traces import TracesResource
traces_resource = TracesResource()
Expand All @@ -228,7 +231,7 @@ def test_list_traces_returns_trace_summaries(self):

# Then list traces
response = self.client.get(
"/audit/v1/traces",
"/audit/v1/traces/",
headers=self.auth_headers
)

Expand All @@ -239,9 +242,9 @@ def test_list_traces_returns_trace_summaries(self):
self.assertIn("cursor", data)

def test_list_traces_with_limit(self):
"""GET /audit/v1/traces?limit=5 respects limit parameter."""
"""GET /audit/v1/traces/?limit=5 respects limit parameter."""
response = self.client.get(
"/audit/v1/traces?limit=5",
"/audit/v1/traces/?limit=5",
headers=self.auth_headers
)

Expand All @@ -255,7 +258,7 @@ class TestAuditTracesGetTreeContract(unittest.TestCase):

@classmethod
def setUpClass(cls):
cls.manager = services.create_service_manager()
cls.manager = services.create_service_manager(shared=False)
cls.manager.setup()
cls.app = cls.manager.audit_app

Expand All @@ -265,6 +268,7 @@ def setUpClass(cls):

@classmethod
def tearDownClass(cls):
cls.manager.reset_test_data()
cls.manager.close()
import campus.storage.testing
campus.storage.testing.reset_test_storage()
Expand Down Expand Up @@ -341,7 +345,7 @@ class TestAuditSpansListContract(unittest.TestCase):

@classmethod
def setUpClass(cls):
cls.manager = services.create_service_manager()
cls.manager = services.create_service_manager(shared=False)
cls.manager.setup()
cls.app = cls.manager.audit_app

Expand All @@ -351,6 +355,7 @@ def setUpClass(cls):

@classmethod
def tearDownClass(cls):
cls.manager.reset_test_data()
cls.manager.close()
import campus.storage.testing
campus.storage.testing.reset_test_storage()
Expand Down Expand Up @@ -414,7 +419,7 @@ class TestAuditSpanGetContract(unittest.TestCase):

@classmethod
def setUpClass(cls):
cls.manager = services.create_service_manager()
cls.manager = services.create_service_manager(shared=False)
cls.manager.setup()
cls.app = cls.manager.audit_app

Expand All @@ -424,6 +429,7 @@ def setUpClass(cls):

@classmethod
def tearDownClass(cls):
cls.manager.reset_test_data()
cls.manager.close()
import campus.storage.testing
campus.storage.testing.reset_test_storage()
Expand Down Expand Up @@ -514,7 +520,7 @@ class TestAuditTracesSearchContract(unittest.TestCase):

@classmethod
def setUpClass(cls):
cls.manager = services.create_service_manager()
cls.manager = services.create_service_manager(shared=False)
cls.manager.setup()
cls.app = cls.manager.audit_app

Expand All @@ -524,6 +530,7 @@ def setUpClass(cls):

@classmethod
def tearDownClass(cls):
cls.manager.reset_test_data()
cls.manager.close()
import campus.storage.testing
campus.storage.testing.reset_test_storage()
Expand Down
Loading