test: fix audit contract test isolation#452
Merged
ngjunsiang merged 1 commit intoweeklyfrom Apr 10, 2026
Merged
Conversation
- Use shared=False for fresh ServiceManager instances per test class - Move reset_test_data() from tearDown() to tearDownClass() - Fix trailing slash URLs to match route definitions (/traces/ not /traces) - Reset data after each test class instead of per-test to avoid reinitializing storage tables between every test Fixes test isolation where data persisted between test classes, causing "no such table: spans" errors after reset_test_data(). Related: Issue #427 Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shared=Falsefor fresh ServiceManager instances per test classreset_test_data()fromtearDown()totearDownClass()to reset between classes rather than per-test/traces/not/traces)Test Plan
Note: Contract tests (
tests/contract/) are not covered byrun_tests.pywhich only supportsunit,integration,sanity,type,allcategories.Run contract tests directly:
Run all supported tests via test entrypoint:
Results
🤖 Generated with Claude Code