Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(validator): remove old todo comment #250

Merged
merged 1 commit into from
Nov 30, 2022
Merged

chore(validator): remove old todo comment #250

merged 1 commit into from
Nov 30, 2022

Conversation

dargmuesli
Copy link
Contributor

See #249.

@netlify
Copy link

netlify bot commented Nov 9, 2022 •
edited
Loading

✅ Deploy Preview for html-validator canceled.

Name Link
🔨 Latest commit 13f18f7
🔍 Latest deploy log https://app.netlify.com/sites/html-validator/deploys/636b4d2d981f2800087cde3a

@dargmuesli dargmuesli mentioned this pull request Nov 9, 2022
Open
danielroe
danielroe reviewed Nov 30, 2022
View reviewed changes
Copy link
Collaborator

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is still relevant - see:

r.default?.default ?? r.default ?? r

@danielroe
Copy link
Collaborator

oh, I see 🤦 - thank you!

@danielroe danielroe merged commit 9ac9f29 into nuxt-modules:main Nov 30, 2022
@dargmuesli dargmuesli deleted the chore/old-todo branch November 30, 2022 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dargmuesli @danielroe