Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
452 commits
Select commit Hold shift + click to select a range
9097989
Merge pull request #109 from Spyobird/spyobird-v1.3-update-commands
ianfromdover Mar 31, 2022
d2cefda
Remove `Rate` from `Job`
Spyobird Mar 31, 2022
757d9e1
Update functionality of `JobMarkCommand` to handle `Payment`s
Spyobird Mar 31, 2022
45d314a
Add `JobFinalizeCommand`
Spyobird Mar 31, 2022
fb662d5
Add amount due functionality in `Person` for UI
Spyobird Mar 31, 2022
e75921d
Merge pull request #128 from Spyobird/spyobird-v1.3-handle-payments
ianfromdover Mar 31, 2022
8990eed
Fix cosmetic issues like jar name
ianfromdover Mar 31, 2022
6cc526b
Display finalise payment and outstanding salary in UI
ianfromdover Mar 31, 2022
a2374cd
Add fix where marked `Job`s cannot be assigned
Spyobird Mar 31, 2022
7415941
Add potential fix for sample data `personIDState` starting at 0
Spyobird Mar 31, 2022
7785138
Update changes to the UG
Spyobird Mar 31, 2022
f9120d6
Update Ui.png and briefly describe changes in UG
ianfromdover Mar 31, 2022
c5efd36
Merge pull request #136 from Spyobird/spyobird-update-ug
ianfromdover Mar 31, 2022
9dc4b78
Merge pull request #135 from Spyobird/spyobird-v1.3-handle-payments
ianfromdover Mar 31, 2022
09c4076
Merge branch 'master' into ian-polish-ui
ianfromdover Mar 31, 2022
798740d
Merge pull request #125 from ian-from-dover/ian-polish-ui
Spyobird Apr 1, 2022
1302619
Fix `EditCommand` not working with `Rate`
Spyobird Apr 1, 2022
a4fea29
Merge pull request #140 from Spyobird/spyobird-v1.3-quick-fix-edit
zhongfu Apr 1, 2022
17a2b75
Make minor UG edits
ovidharshini Apr 1, 2022
6dab7cd
Change markdown parser for Jekyll
Spyobird Apr 2, 2022
1ad8c97
Merge pull request #199 from AY2122S2-CS2103T-T11-4/spyobird-md-parse
ianfromdover Apr 2, 2022
3f0ca71
Remove comments for team members #149
zhongfu Apr 2, 2022
89764f4
Merge pull request #160 from ovidharshini/ovidharshini-UG-edits
zhongfu Apr 2, 2022
2bdff38
Update UG to disambiguate format for `help` #145
zhongfu Apr 2, 2022
c6c42f8
Remove erroneous rate arg in UG `job` desc #151
zhongfu Apr 2, 2022
c87934d
Update references to `mark` section in UG #152
zhongfu Apr 2, 2022
0d41c58
Reorder `mark` and `assign` sections in UG #180
zhongfu Apr 2, 2022
0c41d4e
Clarify behavior for editing employee rates #191
zhongfu Apr 2, 2022
0a1dca1
Elaborate on some UG examples
zhongfu Apr 2, 2022
70192b0
Merge pull request #200 from zhongfu/zhongfu/ug-fixes
ianfromdover Apr 3, 2022
4055c68
Fix `Duration` taking on negative or extreme values
Spyobird Apr 6, 2022
73d516b
Fix `assign` to correctly display errors with paid jobs
Spyobird Apr 6, 2022
6b5c157
Add user documentation for `jobfind`
Spyobird Apr 6, 2022
c75af82
Fix error not showing for negative `Rate` in `add`
Spyobird Apr 6, 2022
6920563
Display base pay
ianfromdover Apr 6, 2022
6c6c33f
Make toString of Rate return something easy to read
ianfromdover Apr 6, 2022
3223e1c
Make Durations human-readable in GUI
ianfromdover Apr 6, 2022
6a3d5ee
Format displayed duration in hours and minutes
ianfromdover Apr 6, 2022
70a743b
Fix checkstyle
ianfromdover Apr 6, 2022
076e6f6
Avoid using Desktop.browse() on Linux #108
zhongfu Apr 7, 2022
27fdbab
Force label tags to wrap #169
zhongfu Apr 7, 2022
735d688
Merge pull request #209 from zhongfu/zhongfu/wrap-tag-text
ianfromdover Apr 7, 2022
ec80330
Merge pull request #208 from zhongfu/zhongfu/fix-linux-desktop-browse…
ianfromdover Apr 7, 2022
8f9124f
Add a word to UG
ianfromdover Apr 7, 2022
f3cf9a5
Revert unnecessary change
Spyobird Apr 7, 2022
bdb0faa
Merge pull request #204 from Spyobird/spyobird-v1.4-bug-fixes
Spyobird Apr 7, 2022
916996f
Add space btwn hrs & mins in duration, fix placeholders
ianfromdover Apr 7, 2022
049971d
fix rate toString conflict
ianfromdover Apr 7, 2022
e9cda09
Merge pull request #205 from ian-from-dover/ian-polish-ui
ianfromdover Apr 7, 2022
cebca73
Rename command words
ovidharshini Apr 8, 2022
8182bcd
Refactor class names
ovidharshini Apr 8, 2022
a9c004e
Refactor parser person packages
ovidharshini Apr 8, 2022
3eb3f3d
Add git hook to fix fxml versions
zhongfu Apr 8, 2022
7e42752
Change fxml xmlns attrs to point to xmlns for javafx 11
zhongfu Apr 8, 2022
be4f50b
Update UserGuide.md
thewrik Apr 8, 2022
a9f12e5
Merge pull request #213 from thewrik/thewrik_v1.4_UG_fix#1
ovidharshini Apr 8, 2022
1ae399a
Fix possible race in PersonEditCommandTest
zhongfu Apr 8, 2022
924e290
Change PersonAdd command name
ovidharshini Apr 8, 2022
4fb126e
Merge pull request #210 from ovidharshini/ovidharshini-rename-command
zhongfu Apr 8, 2022
dd50858
Merge pull request #212 from zhongfu/zhongfu/fix-fxml-version
ianfromdover Apr 8, 2022
83c6db7
Add format and example to commands
ovidharshini Apr 8, 2022
e0e39b8
Add class to handle help messages
ovidharshini Apr 8, 2022
2d08cbf
Add tests for parsing help messages
ovidharshini Apr 8, 2022
74d1c38
Resolve duplicate person addition
ovidharshini Apr 9, 2022
3457ed6
Add separate function to check for duplicate persons
ovidharshini Apr 9, 2022
225cee4
Allow border pane and main pane to fill width
zhongfu Apr 9, 2022
56fd9d3
Coerce undersized window dimensions in GuiSettings to min dimensions
zhongfu Apr 9, 2022
36bc109
Bind job/person card col widths to header col widths
zhongfu Apr 9, 2022
c1aaf14
Update width constraints on {Job,Person} list cols
zhongfu Apr 9, 2022
717145f
Use min height/width fields from GuiSettings in MainWindow
zhongfu Apr 9, 2022
9888e5b
Remove parsing functions in CommandHelpMessage
ovidharshini Apr 10, 2022
cb66d2b
Apply suggestions from code review
ovidharshini Apr 10, 2022
3d5ca3d
Remove trailing whitespaces
zhongfu Apr 10, 2022
f0a9745
Merge pull request #217 from ovidharshini/ovidharshini-handle-duplica…
zhongfu Apr 10, 2022
c14b089
Fix bad ref to GuiSettings class constants in fxml
zhongfu Apr 10, 2022
306c943
Merge pull request #218 from zhongfu/zhongfu/fix-gui-width
ianfromdover Apr 10, 2022
1615090
Debug and fix ResultDisplay messages for all job commands
ianfromdover Apr 8, 2022
f6205d6
Update related tests
ianfromdover Apr 8, 2022
40725c7
Fix rebase conflicts due to renaming
ianfromdover Apr 8, 2022
c2d3dca
Make ResultDisplay scrollable
ianfromdover Apr 8, 2022
bac9bed
Fix tests using the new messages
ianfromdover Apr 8, 2022
978528b
Add 2 missing tests
ianfromdover Apr 8, 2022
642a3f5
Ensure all commands have format+eg, add export note
ianfromdover Apr 10, 2022
155c15a
Add date/time to end of export filename to avoid accidentally clobber…
zhongfu Apr 10, 2022
79cdc63
Merge pull request #220 from zhongfu/zhongfu/datetime-in-export-filename
ianfromdover Apr 10, 2022
17307de
Address language from comments
ianfromdover Apr 10, 2022
fe47ba2
Merge pull request #214 from ian-from-dover/ian-polish-ui
ianfromdover Apr 10, 2022
43ced05
Add data to TableView on helpPage
ovidharshini Apr 10, 2022
5d52926
Merge branch 'master' into ovidharshini-help-command
ovidharshini Apr 10, 2022
6f68439
Edit DG diagram colours
ianfromdover Apr 10, 2022
82a2bbf
Update DG UI Section and all diagrams with new colours
ianfromdover Apr 10, 2022
0804c23
Update DG diagram cols to be more visible
ianfromdover Apr 10, 2022
321796d
Replace HiddenOutsides with invisible classes
ianfromdover Apr 10, 2022
7fcd267
Merge pull request #221 from ian-from-dover/ian-dg
ianfromdover Apr 10, 2022
59bfcc1
Add (reusable) table pane component
zhongfu Apr 8, 2022
5fd44d2
Tidy up table pane stuff
zhongfu Apr 9, 2022
4fcef5f
hotfix for failing tests
ianfromdover Apr 10, 2022
566e615
Add UI GIF for README and index.md
ianfromdover Apr 10, 2022
a0615bd
Add high res icons
ianfromdover Apr 10, 2022
88c36e9
Beautify help browser open button
ianfromdover Apr 10, 2022
784b736
Make app use internal font files
ianfromdover Apr 10, 2022
fc39136
Make PageSwitcher assoc class to switch pages and update btn
ianfromdover Apr 10, 2022
b23efd8
Outline Ian's contribution in his PPP
ianfromdover Apr 3, 2022
38c57d3
Add more contributions
ianfromdover Apr 6, 2022
b724e00
Complete Ian's PPP
ianfromdover Apr 10, 2022
8e3a5f8
address Oviya's suggestions
ianfromdover Apr 10, 2022
2911f4e
Fix whitespace issues
ovidharshini Apr 10, 2022
7220f86
Merge pull request #202 from ian-from-dover/ian-ppp
ovidharshini Apr 10, 2022
e598394
Add tests for job command classes
ovidharshini Apr 11, 2022
58ff75e
Merge pull request #224 from ovidharshini/ovidharshini-add-tests
ianfromdover Apr 11, 2022
37eabc6
Add help/command table styling
zhongfu Apr 11, 2022
ac394fd
Rejiggle helpMessageContainer a lil bit
zhongfu Apr 11, 2022
4cde44f
Add whitespace at end of file
zhongfu Apr 11, 2022
f6c4f05
Merge pull request #222 from ian-from-dover/ian-dg
ianfromdover Apr 11, 2022
a803dca
Implement job-person assignment display with barebones look
ianfromdover Apr 8, 2022
8ded0ad
Make assignments pretty like tags
ianfromdover Apr 9, 2022
5905cc0
Add jobCard FXML updates
ianfromdover Apr 9, 2022
b42370c
Remove numbering from assignment
ianfromdover Apr 11, 2022
d6fb2b4
joblist: make Done col not hide title on resizing
ianfromdover Apr 11, 2022
3863704
Fix ResultDisplay showing white box
ianfromdover Apr 11, 2022
9951118
Merge branch 'master' into ovidharshini-help-command
zhongfu Apr 11, 2022
6ebcbce
Merge pull request #215 from ovidharshini/ovidharshini-help-command
zhongfu Apr 11, 2022
1a5fc14
Merge branch 'master' into ian-show-asgn
zhongfu Apr 11, 2022
69f1c84
Merge pull request #216 from ian-from-dover/ian-show-asgn
zhongfu Apr 11, 2022
94c2ece
Update UserGuide.md
thewrik Apr 11, 2022
b398843
Update UserGuide.md
thewrik Apr 11, 2022
2d45d93
Update UserGuide.md
thewrik Apr 11, 2022
2b81424
Add tests for JobAssignCommand
ovidharshini Apr 11, 2022
504d504
Add more tests for job-related classes
ovidharshini Apr 11, 2022
74d9652
Remove side effects from Employment::getPersons
zhongfu Apr 11, 2022
1350869
Merge pull request #225 from thewrik/thewrik_v1.4_UGfix#5
ovidharshini Apr 11, 2022
49bda97
Add base color back into DarkTheme
zhongfu Apr 11, 2022
f059ea1
Disable selection and focus for help/employee/job tables
zhongfu Apr 11, 2022
693ef8c
Fix formatting inconsistencies in Ian's PPP
ianfromdover Apr 11, 2022
8a8a9e7
Adjust person tag/unpaid col widths
zhongfu Apr 11, 2022
6efc298
Align tags/assigned label text to the left
zhongfu Apr 11, 2022
6fec6fd
Move proposed impl designs to end of impl section in DG
zhongfu Apr 11, 2022
fb63b43
Create PaymentTest.java
thewrik Apr 11, 2022
bcb8759
Minor DG edits
ovidharshini Apr 11, 2022
3ff7646
Refactor HelpPage to use data from MainWindow
ovidharshini Apr 11, 2022
0e39979
Add proposed implementation for data archiving function
zhongfu Apr 11, 2022
487fbee
Update PaymentTest.java
thewrik Apr 11, 2022
23e3af4
Update codebase line count in README.md
zhongfu Apr 11, 2022
1be6ca7
Minor DG edits
ovidharshini Apr 11, 2022
2f8d43d
Add user stories
ovidharshini Apr 11, 2022
cd5f17d
Merge pull request #231 from zhongfu/zhongfu/docs-changes
ovidharshini Apr 11, 2022
b9c69fb
Merge branch 'master' into ovidharshini-minor-dg-updates
ovidharshini Apr 11, 2022
0b1724a
Merge pull request #227 from ian-from-dover/ian-p
Spyobird Apr 11, 2022
66b0cf9
Merge pull request #233 from ovidharshini/ovidharshini-minor-dg-updates
Spyobird Apr 11, 2022
405b7ce
Update PaymentTest.java
thewrik Apr 11, 2022
249aeb7
Update PaymentTest.java
thewrik Apr 11, 2022
d8645a6
Add PPP for zhongfu
zhongfu Apr 11, 2022
9b2211a
Documentation Updated
thewrik Apr 11, 2022
4de0855
Update AddressTest.java
thewrik Apr 11, 2022
bca58f3
Merge pull request #226 from ovidharshini/ovidharshini-add-tests
thewrik Apr 11, 2022
8f0a03f
Update multiplier tag section of DG
ovidharshini Apr 11, 2022
ddd4989
Apply suggestions from code review
zhongfu Apr 11, 2022
c29d5d0
Merge pull request #235 from zhongfu/zhongfu/zhongfu-ppp
zhongfu Apr 11, 2022
fe4aec0
Merge pull request #228 from zhongfu/zhongfu/fix-ui
ianfromdover Apr 11, 2022
78ba6fd
Merge pull request #237 from ovidharshini/ovidharshini-minor-dg-updates
Spyobird Apr 11, 2022
09200bb
UG updates
thewrik Apr 11, 2022
c639cd5
Completely standardise notation
ianfromdover Apr 11, 2022
a0777b6
Fix checkstyle
ianfromdover Apr 11, 2022
5a902be
Update DG with `Logic` changes
Spyobird Apr 11, 2022
225f2cb
Update src/test/java/peoplesoft/model/money/PaymentTest.java
thewrik Apr 11, 2022
dee7c87
Add Assign Feature, Warnings
thewrik Apr 11, 2022
1beafa8
Merge pull request #238 from ian-from-dover/ian-p
ianfromdover Apr 11, 2022
d4c0ba5
Add extra spacing to PPP
zhongfu Apr 11, 2022
e7c031b
Update Model part of DG
Spyobird Apr 11, 2022
e63103d
Update PPP
ovidharshini Apr 11, 2022
710870f
Use full names in AboutUs.md
zhongfu Apr 11, 2022
49a673d
Merge pull request #239 from zhongfu/zhongfu/ppp-docs-2
zhongfu Apr 11, 2022
2f175eb
Merge pull request #230 from thewrik/thewrik_v1.4_PaymentTest
ianfromdover Apr 11, 2022
641ce8f
Merge pull request #236 from thewrik/thewrik_v1.4_UGfix#5
ianfromdover Apr 11, 2022
f357ec7
Update docs/DeveloperGuide.md
ianfromdover Apr 11, 2022
aa5950d
Update docs/DeveloperGuide.md
ianfromdover Apr 11, 2022
7f23b05
Merge pull request #240 from Spyobird/spyobird-v1.4-DG
ianfromdover Apr 11, 2022
d0c3b1a
Merge pull request #241 from ovidharshini/ovidharshini-update-ppp
ianfromdover Apr 11, 2022
4fc7611
Fix Employment::getJobs
zhongfu Apr 11, 2022
4786f1a
Fix exporter output
zhongfu Apr 11, 2022
2993628
Add some use cases
ovidharshini Apr 11, 2022
b328d86
Merge pull request #243 from zhongfu/zhongfu/fix-exporter-output
zhongfu Apr 11, 2022
6310b7d
Merge pull request #244 from ovidharshini/ovidharshini-use-cases
thewrik Apr 11, 2022
b0c7301
Update PPP and some aspects of the UG
Spyobird Apr 11, 2022
c112416
Update UG
Spyobird Apr 11, 2022
ebc24e7
Change headings of UG
Spyobird Apr 11, 2022
b5908c0
Finalize UG and PPP changes
Spyobird Apr 11, 2022
a9bdd67
Merge pull request #234 from Spyobird/spyobird-v1.4-documentation
Spyobird Apr 11, 2022
def766b
Update PPP
Spyobird Apr 11, 2022
0df8cb8
Merge pull request #245 from Spyobird/spyobird-v1.4-documentation
Spyobird Apr 11, 2022
d8ab6cd
Update PPP
Spyobird Apr 11, 2022
d807125
Merge branch 'master' into spyobird-v1.4-documentation
Spyobird Apr 11, 2022
5bef0f4
Merge pull request #246 from Spyobird/spyobird-v1.4-documentation
Spyobird Apr 11, 2022
9bf1118
Fix contents and table
Spyobird Apr 13, 2022
22db8ee
Merge pull request #247 from Spyobird/spyobird-2101-documentation
ovidharshini Apr 14, 2022
d978817
Replace awkward phrasing in command headers
zhongfu Apr 14, 2022
d2ed679
Rephrase UG introduction
zhongfu Apr 14, 2022
f75ccd7
Disambiguate UG installation instructions, remove extraneous formatting
zhongfu Apr 14, 2022
9fd07c9
Update UG tutorial
zhongfu Apr 14, 2022
92248fa
Add links to UG sections in command summary table
zhongfu Apr 14, 2022
91fdc59
Add info about info and warning boxes + use them
zhongfu Apr 14, 2022
01f321b
Update person-related command reference in UG
zhongfu Apr 14, 2022
a18fc6f
Update job-related command ref in UG
zhongfu Apr 14, 2022
ff3a0aa
Update misc command ref in UG
zhongfu Apr 14, 2022
8c87653
Update FAQ in UG
zhongfu Apr 14, 2022
de607d1
Update UG glossary + sort alphabetically
zhongfu Apr 14, 2022
ce674ca
Add extra line breaks to delineate FAQ items
zhongfu Apr 14, 2022
4279f75
Add missing newline on UserGuide.md
zhongfu Apr 15, 2022
d1c555e
Remove lines with only spaces on markdown files
zhongfu Apr 15, 2022
bbcc579
Remove lines ending with single space on markdown files
zhongfu Apr 15, 2022
3cd3cad
Move `assign` screenshots out of infobox
zhongfu Apr 15, 2022
2a54f58
Apply suggestions from code review
zhongfu Apr 15, 2022
6dda6b7
Merge pull request #248 from zhongfu/zhongfu/ug-fixes
ianfromdover Apr 15, 2022
34f0e8a
Add Return to Table of Contents link to all sections
ianfromdover Apr 15, 2022
9ee2ef5
language and icon fixes
ianfromdover Apr 15, 2022
f3ea771
Add new images for all images and add captions
ianfromdover Apr 15, 2022
207cb60
Fix information box becoming code
ianfromdover Apr 15, 2022
968bccc
Merge pull request #249 from ian-from-dover/ian-ug
ovidharshini Apr 15, 2022
e64afeb
Replace mentions of "table" -> "list" in UG
zhongfu Apr 15, 2022
dc51375
Standardize on double quotes in UG
zhongfu Apr 15, 2022
a2605c6
Fix broken links (again)
zhongfu Apr 15, 2022
3614b77
Standardize app -> application
zhongfu Apr 15, 2022
c756653
Fix spacing in command ref table
zhongfu Apr 15, 2022
fc35935
Ummm, "the application" -> "PeopleSoft"
zhongfu Apr 15, 2022
fa7e30f
Fix checkmark emoji in UG
zhongfu Apr 15, 2022
cecb4d2
Remove extraneous [t/TAG]
zhongfu Apr 15, 2022
e8df8f4
Merge pull request #251 from zhongfu/zhongfu/ug-fixes-2
ovidharshini Apr 15, 2022
35e357e
Minor caption style changes
zhongfu Apr 15, 2022
05e9433
Replaced cross emoji img with tick emoji img
zhongfu Apr 15, 2022
139040a
Capitalize "enter"
zhongfu Apr 15, 2022
055fc8a
Replace some references to "application", "program" to "PeopleSoft"
zhongfu Apr 15, 2022
e6dc4af
Spelling, grammar, punctuation, etc changes
zhongfu Apr 15, 2022
b77ed13
Consistency changes
zhongfu Apr 15, 2022
7958531
Phrasing changes
zhongfu Apr 15, 2022
eeb249a
Merge pull request #253 from zhongfu/zhongfu/ug-fixes-2
ovidharshini Apr 15, 2022
86a0720
Fix rebase issues
ovidharshini Apr 15, 2022
6d12d27
Add parameter constraints
ovidharshini Apr 15, 2022
1023395
Remove extraneous line from UG
ovidharshini Apr 15, 2022
30b14f6
Merge pull request #252 from ovidharshini/ovidharshini-update-user-guide
zhongfu Apr 15, 2022
b5842e7
Update how to use UG section
ovidharshini Apr 15, 2022
c7ab694
Add padding below captions
zhongfu Apr 15, 2022
6218b7d
Replace mentions of "person" with "employee"
zhongfu Apr 15, 2022
1ae89c3
Fix table formatting issue
zhongfu Apr 15, 2022
cbbd5ea
Some ui changes
ovidharshini Apr 15, 2022
1f33db1
"a employee" -> "an employee"
zhongfu Apr 15, 2022
6f11fb6
Add newline at EOF for style.scss
zhongfu Apr 15, 2022
7440ce0
Merge pull request #254 from zhongfu/zhongfu/ug-fixes-2
Spyobird Apr 15, 2022
9cca132
Update docs/UserGuide.md
ovidharshini Apr 15, 2022
263b880
Merge branch 'master' into ovidharshini-update-user-guide
zhongfu Apr 15, 2022
87d625e
Merge pull request #255 from ovidharshini/ovidharshini-update-user-guide
zhongfu Apr 15, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
28 changes: 28 additions & 0 deletions .githooks/pre-commit
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
#!/usr/bin/env bash
set -Eeuo pipefail
trap fail ERR

TYPE="$(basename $0)"
TYPE_UPPER="${TYPE^}"

function fail() {
if [ -n "${filename:-}" ]; then
echo -e '\033[1;91m### '"$TYPE_UPPER"' script '"$filename"' failed!\033[0m'
else
echo -e '\033[1;91m### '"$TYPE_UPPER"' hooks failed for an unknown reason!\033[0m'
fi
exit 1
}

# assume we're in repo root

if [[ -d .git/hooks/${TYPE}.d ]]; then
for script in .git/hooks/${TYPE}.d/*; do
if [[ -f "$script" && -x "$script" ]]; then
filename="$(basename "$script")"
echo -e '\033[1;96m### Running '"$TYPE"' script '"$filename"'\033[0m'
bash $script
echo -e '\033[1;96m### Finished running '"$TYPE"' script '"$filename"'\033[0m\n'
fi
done
fi
29 changes: 29 additions & 0 deletions .githooks/pre-commit.d/fix-fxml-versions
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
#!/bin/bash
set -euo pipefail
JAVAFX_VER=11

# only care about staged changes for files ending in .fxml
git diff --cached --name-only | { grep -E "src/main/.*\.fxml$" || test $? == 1; } | while read fn; do
# suppress only exit code 1; let set -e catch everything else
javafx_lines="$(git show ":$fn" | { grep -E -o 'http://javafx.com/javafx/[^"]+' || test $? == 1; })"

# sanity check: only one line
javafx_num_lines=$(wc -l <<< "$javafx_lines")
if [[ $javafx_num_lines -ne 1 ]]; then
>&2 echo "error: staged file $fn doesn't have exactly 1 line with javafx xmlns url (got: $javafx_num_lines)"
exit 1
fi

javafx_cur_ver=$(grep -E -o "[0-9]+" <<< "$javafx_lines")

if [[ $javafx_cur_ver -ne $JAVAFX_VER ]]; then
echo "staged file $fn has incorrect javafx ver $javafx_cur_ver; changing to ver $JAVAFX_VER in working tree and index"
# working tree, hopefully it breaks nothing
sed -i "s|http://javafx.com/javafx/$javafx_cur_ver|http://javafx.com/javafx/$JAVAFX_VER|" "$fn" || test $? == 1

# index (i.e. staged)
partial_patch="$(git show ":$fn" | sed "s|http://javafx.com/javafx/$javafx_cur_ver|http://javafx.com/javafx/$JAVAFX_VER|" | { diff -u <(git show ":$fn") - || test $? == 1; } | tail -n +3)"
patch="--- a/$fn"$'\n'"+++ b/$fn"$'\n'"$partial_patch"
git apply --cached <<< "$patch"
fi
done
20 changes: 20 additions & 0 deletions .githooks/pre-commit.d/gradle-checks
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
#!/bin/bash
set -euo pipefail

# https://stackoverflow.com/a/3466183/1675299

unameOut="$(uname -s)"
case "${unameOut}" in
Linux*) machine=Linux;;
Darwin*) machine=Mac;;
CYGWIN*) machine=Cygwin;;
MINGW*) machine=MinGw;;
*) machine="UNKNOWN:${unameOut}"
esac

if [[ "$machine" == "Cygwin" || "$machine" == "MinGw" ]]; then
./gradlew.bat check
else
# assume *nix, I guess
./gradlew check
fi
2 changes: 1 addition & 1 deletion .github/workflows/gradle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
- name: Build and check with Gradle
run: ./gradlew check coverage

- uses: codecov/codecov-action@v1
- uses: codecov/codecov-action@v2
if: runner.os == 'Linux'
with:
file: ${{ github.workspace }}/build/reports/jacoco/coverage/coverage.xml
Expand Down
10 changes: 8 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,26 @@
/build/
src/main/resources/docs/

# IDEA files
# IDEA and other IDE files
/.idea/
/out/
/*.iml
/.vscode/

# Misc build files
/bin/

# Storage/log files
/data/
/data/ Change the sample details
/config.json
/preferences.json
/*.log.*
/data/

# Test sandbox files
src/test/data/sandbox/

# MacOS custom attributes files created by Finder
.DS_Store
docs/_site/
gradle/wrapper/gradle-wrapper.properties
30 changes: 16 additions & 14 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
[![CI Status](https://github.com/se-edu/addressbook-level3/workflows/Java%20CI/badge.svg)](https://github.com/se-edu/addressbook-level3/actions)

![Ui](docs/images/Ui.png)

* This is **a sample project for Software Engineering (SE) students**.<br>
Example usages:
* as a starting point of a course project (as opposed to writing everything from scratch)
* as a case study
* The project simulates an ongoing software project for a desktop application (called _AddressBook_) used for managing contact details.
* It is **written in OOP fashion**. It provides a **reasonably well-written** code base **bigger** (around 6 KLoC) than what students usually write in beginner-level SE modules, without being overwhelmingly big.
* It comes with a **reasonable level of user and developer documentation**.
* It is named `AddressBook Level 3` (`AB3` for short) because it was initially created as a part of a series of `AddressBook` projects (`Level 1`, `Level 2`, `Level 3` ...).
* For the detailed documentation of this project, see the **[Address Book Product Website](https://se-education.org/addressbook-level3)**.
* This project is a **part of the se-education.org** initiative. If you would like to contribute code to this project, see [se-education.org](https://se-education.org#https://se-education.org/#contributing) for more info.
[![CI Status](https://github.com/AY2122S2-CS2103T-T11-4/tp/actions/workflows/gradle.yml/badge.svg)](https://github.com/AY2122S2-CS2103T-T11-4/tp/actions/workflows/gradle.yml)
[![Codecov](https://codecov.io/gh/AY2122S2-CS2103T-T11-4/tp/branch/master/graph/badge.svg?token=Z0PQIQXY29)](https://codecov.io/gh/AY2122S2-CS2103T-T11-4/tp)

![Ui](docs/images/Ui.gif)

PeopleSoft is a CLI-based contractor payroll management app. It helps **companies which offer contractor services** with managing how much each contractor is paid. You can:
- manage contractors
- manage jobs
- calculate monthly salary

It is written with the OOP paradigm in mind and has ~11 KLoC.
View the User Guide and Developer Guide on our **[Website](https://ay2122s2-cs2103t-t11-4.github.io/tp/)**.
## Credits
Inter Font from https://github.com/rsms/inter

This project is based on the AddressBook-Level3 project created by the [SE-EDU initiative](https://se-education.org).
20 changes: 12 additions & 8 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ plugins {
id 'jacoco'
}

mainClassName = 'seedu.address.Main'
mainClassName = 'peoplesoft.Main'

sourceCompatibility = JavaVersion.VERSION_11
targetCompatibility = JavaVersion.VERSION_11
Expand All @@ -20,11 +20,6 @@ checkstyle {
toolVersion = '8.29'
}

test {
useJUnitPlatform()
finalizedBy jacocoTestReport
}

task coverage(type: JacocoReport) {
sourceDirectories.from files(sourceSets.main.allSource.srcDirs)
classDirectories.from files(sourceSets.main.output)
Expand All @@ -40,8 +35,13 @@ task coverage(type: JacocoReport) {
}
}

test {
useJUnitPlatform()
finalizedBy coverage
}

dependencies {
String jUnitVersion = '5.4.0'
String jUnitVersion = '5.8.2'
String javaFxVersion = '11'

implementation group: 'org.openjfx', name: 'javafx-base', version: javaFxVersion, classifier: 'win'
Expand All @@ -66,7 +66,11 @@ dependencies {
}

shadowJar {
archiveName = 'addressbook.jar'
archiveName = 'peoplesoft.jar'
}

run {
enableAssertions = true
}

defaultTasks 'clean', 'test'
14 changes: 14 additions & 0 deletions config/checkstyle/checkstyle.xml
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,20 @@

<module name="Indentation">
<property name="caseIndent" value="0" />
<property name="lineWrappingIndentation" value="8" />
<!-- note: forceStrictCondition not used because we might want to have more than 8 spaces
e.g.:

blah.blah()
.blah()
.blah()
.blah()
.blag(Abc.def()
.efg());

forceStrictCondition doesn't take this into account, and forces the last line
to be at 8 indentation
-->
</module>

<module name="NoWhitespaceBefore">
Expand Down
62 changes: 62 additions & 0 deletions data.example/addressbook.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
{
"persons" : [ {
"id" : "1",
"name" : "Nicole Tan",
"phone" : "99338558",
"email" : "nicole@stffhub.org",
"address" : "1 Tech Drive, S138572",
"rate" : {
"amount" : "30.000000",
"duration" : "PT1H"
},
"tagged" : [ "Intern", "Aircon" ]
}, {
"id" : "2",
"name" : "Kavya Singh",
"phone" : "96736637",
"email" : "kavya@stffhub.org",
"address" : "2 Orchard Turn, S238801",
"rate" : {
"amount" : "40.000000",
"duration" : "PT1H"
},
"tagged" : [ "Senior", "Electrician" ]
}, {
"id" : "3",
"name" : "Ethan Lee",
"phone" : "91031282",
"email" : "ethan@stffhub.org",
"address" : "10 Anson Road, S079903",
"rate" : {
"amount" : "20.000000",
"duration" : "PT1H"
},
"tagged" : [ "Appliances" ]
}, {
"id" : "4",
"name" : "Irfan Ibrahim",
"phone" : "92492021",
"email" : "irfan@stffhub.org",
"address" : "Blk 47 Tampines Street 20, #17-35",
"rate" : {
"amount" : "48.000000",
"duration" : "PT1H"
},
"tagged" : [ "Painting" ]
}, {
"id" : "5",
"name" : "Arjun Khatau",
"phone" : "80445044",
"email" : "arjun@stffhub.org",
"address" : "50 Collyer Quay, S049321",
"rate" : {
"amount" : "33.000000",
"duration" : "PT1H"
},
"tagged" : [ "Contract", "Aircon" ]
} ],
"jobs" : [ ],
"employment" : { },
"jobIdState" : 0,
"personIdState" : 5
}
52 changes: 19 additions & 33 deletions docs/AboutUs.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,55 +5,41 @@ title: About Us

We are a team based in the [School of Computing, National University of Singapore](http://www.comp.nus.edu.sg).

You can reach us at the email `seer[at]comp.nus.edu.sg`

## Project team

### John Doe
### Li Zhong Fu

<img src="images/johndoe.png" width="200px">
<img src="images/zhongfu.png" width="200px">

[[homepage](http://www.comp.nus.edu.sg/~damithch)]
[[github](https://github.com/johndoe)]
[[portfolio](team/johndoe.md)]
[[github](https://github.com/zhongfu)]
[[portfolio](team/zhongfu.md)]

* Role: Project Advisor
### Hong Yi En, Ian

### Jane Doe
<img src="images/ian-from-dover.png" width="200px">

<img src="images/johndoe.png" width="200px">
[[github](http://github.com/ian-from-dover)]
[[portfolio](team/ian-from-dover.md)]

[[github](http://github.com/johndoe)]
[[portfolio](team/johndoe.md)]
### Wrik Karmakar

* Role: Team Lead
* Responsibilities: UI
<img src="images/thewrik.png" width="200px">

### Johnny Doe
[[github](http://github.com/thewrik)] [[portfolio](team/thewrik.md)]

<img src="images/johndoe.png" width="200px">
### Elliot Lim Zhi Yong

[[github](http://github.com/johndoe)] [[portfolio](team/johndoe.md)]
<img src="images/spyobird.png" width="200px">

* Role: Developer
* Responsibilities: Data
[[github](http://github.com/spyobird)]
[[portfolio](team/spyobird.md)]

### Jean Doe

<img src="images/johndoe.png" width="200px">
### Elumalai Oviya Dharshini

[[github](http://github.com/johndoe)]
[[portfolio](team/johndoe.md)]
<img src="images/ovidharshini.png" width="200px">

* Role: Developer
* Responsibilities: Dev Ops + Threading
[[github](http://github.com/ovidharshini)]
[[portfolio](team/ovidharshini.md)]

### James Doe

<img src="images/johndoe.png" width="200px">

[[github](http://github.com/johndoe)]
[[portfolio](team/johndoe.md)]

* Role: Developer
* Responsibilities: UI
Loading