[CS2103T-T11-4] PeopleSoft#56
Open
ianfromdover wants to merge 452 commits into
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
============================================
- Coverage 72.15% 64.52% -7.64%
- Complexity 399 651 +252
============================================
Files 70 117 +47
Lines 1232 2692 +1460
Branches 125 277 +152
============================================
+ Hits 889 1737 +848
- Misses 311 847 +536
- Partials 32 108 +76
Continue to review full report at Codecov.
|
Update `Job` related commands to use `Index`
Updated `JobAddCommand` to not use `Rate`. Removed uses of `calculateRate()` (`UI` and `Exporter`). Changed `Job` constructor and added `isFinal` field.
`PaymentHandler` does all the coupling work.
Use `pay INDEX y/`, the `y/` is for confirmation. `JobFinalizeCommand` is supposed to be irreversible, no `Job` related functions are allowed to act on a finalized `Job`. This does not stop malicious/error-prone users from modifying the data file and affecting finalized `Job`s. The only command that affects finalized `Job`s is `clear`. From preliminary testing, all features seem to be in good working order. Automated testing for `Job` related command on finalized `Job`s not yet added. `Rate` was removed from `Job` so `UI` requires the changes to remove the placeholder `Rate` values. In removing `Rate` from `Job`, small changes had to be made to `Exporter`, requires some attention. Also refactored classes to the `model.money` package.
Allow PeopleSoft to handle `Payment`s
Update changes to the UG to include `pay`
Small fix for `assign` on marked `Job`s
Make GUI reflect outstanding salary and jobs that can be finalised
Fix `EditCommand` not working with `Rate`
Change markdown parser for Jekyll
Address some of the identified UG bugs
UG fixes part 2
Even more UG fixes
Minor fixes, add parameter constraints
UG: Add padding below captions, replace "person" -> "employee", fix table formatting
Co-authored-by: zhongfu <me@zhongfu.li>
Modify 'how to use this user guide', change command field name, and some minor fixes to UG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PeopleSoft helps companies which offer contractor services with managing how much each contractor is paid. Given that contractors work on an ad-hoc basis, it is a pain to track and calculate fair renumeration for each employee. PeopleSoft solves this by offering:
Manage your contractors at light speed with PeopleSoft ⚡️