Revamped lynx contract deployments for signing infrastructure
#441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dinator and Dispatcher. Moving forward these contracts will be easier to upgrade - the pain point is just this time.
…ter updated deployment
derekpierre
force-pushed
the
new-signing-coordinator
branch
from
ba384dd to
371cfe0
Compare
7 tasks
derekpierre
changed the title
lynx contract deployments for signing infrastructurelynx contract deployments for signing infrastructure
Fully redeploy root signing infrastructure since old SigningCoordinatorChild was out of sync.
…torChild was out of sync.
…t was already previously deployed.
…did not update old SigningCoordinatorChild which became out of sync with new SigningCoordinator. Really the entire infra needed to be fully deployed again i.e. everything started from scratch. Since the contracts are now properly proxied, upgrading will be easier moving forward.
derekpierre
changed the title
lynx contract deployments for signing infrastructurelynx contract deployments for signing infrastructure
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the version from 0.26.0-alpha.1 to 0.26.0-alpha.2, introducing several infrastructure improvements and dependency updates.
- Updates SigningCoordinatorDispatcher contract to use upgradeable proxy pattern with proper initialization
- Enhances verify.py script to support verification of multiple contracts simultaneously
- Adds new script for deploying signing cohorts on additional chains
Reviewed Changes
Copilot reviewed 10 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_signing_coordinator.py | Updates test fixture to deploy SigningCoordinatorDispatcher as a proxied contract with proper initialization |
| setup.cfg | Version bump to 0.26.0-alpha.2 |
| scripts/verify.py | Refactors to accept multiple contract names and verify them in batch |
| scripts/signing_cohort_additional_chain.py | New script for deploying signing cohorts on additional chains for already formed cohorts |
| requirements.txt | Updates multiple Python dependencies (contains several future version numbers) |
| package.json | Version bump to 0.26.0-alpha.2 |
| package-lock.json | Updates lock file to reflect package.json version change |
| deployment/constructor_params/lynx/root-signing-infra.yml | Adds proxy initialization configuration for SigningCoordinatorDispatcher |
| deployment/constructor_params/lynx/child-signing-infra-base.yml | Updates SigningCoordinatorDispatcher address reference |
| deployment/artifacts/lynx.json | Updates contract addresses and ABIs for redeployed contracts on lynx network |
| contracts/contracts/coordination/SigningCoordinatorDispatcher.sol | Migrates to upgradeable pattern using Initializable and OwnableUpgradeable |
| Pipfile | Updates nucypher-core Git reference from "handover" to "main" branch |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
derekpierre
requested review from
KPrasch,
Muhammad-Altabba,
cygnusv,
manumonti,
theref and
vzotova
cygnusv
approved these changes
Nov 10, 2025
| flake8 = "*" | ||
| isort = "*" | ||
| nucypher-core = { git = "https://github.com/nucypher/nucypher-core.git", ref = "handover", subdirectory = "nucypher-core-python" } | ||
| nucypher-core = { git = "https://github.com/nucypher/nucypher-core.git", ref = "main", subdirectory = "nucypher-core-python" } |
7 tasks
vzotova
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
Overall we need to redeploy
SigningCoordinatorandSigningCoordinatorDispatcherto be properly proxied. In this case the addresses of the contracts change, so we need to update other things. After this deployment they will be properly proxied, so next time we'll just upgrade the contracts without changing the address and some additional steps will no longer need to be done.lynx- these contracts are now properly proxied so will require only an upgrade the next time (we have to pay the price this time)lynxregistryAdditionally:
Issues fixed/closed:
Why it's needed:
Notes for reviewers: