-
Notifications
You must be signed in to change notification settings - Fork 12
[EPIC] Signing Infra #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
derekpierre
wants to merge
98
commits into
main
Choose a base branch
from
signing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[EPIC] Signing Infra #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5d47a0f to
f6ac21b
Compare
… SigningCoordinator contract.
…or cohort participant.
…note this is specific to the same chain as the signing coordinator.
…s are not allowed.
…being invalid - need to improve upgrade process through reinitializers next time.
…e on Ethereum with SigningCoordinatorChild contracts on L2s.
…olia <-> Base Sepolia.
…ographical ordering.
Split Operator and Signer
Properly sort testnet nodes
Signing Request key
…dinator and Dispatcher. Moving forward these contracts will be easier to upgrade - the pain point is just this time.
…ter updated deployment
Fully redeploy root signing infrastructure since old SigningCoordinatorChild was out of sync.
…torChild was out of sync.
…t was already previously deployed.
…did not update old SigningCoordinatorChild which became out of sync with new SigningCoordinator. Really the entire infra needed to be fully deployed again i.e. everything started from scratch. Since the contracts are now properly proxied, upgrading will be easier moving forward.
…address when registering and the chain is the current chain. Add tests for SigningCoordinatorDispatcher.
Revamped `lynx` contract deployments for signing infrastructure
`ThresholdSigningMultisig` tests
More testing of Signing Contracts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
lynxcontract deployments for signing infrastructure #441ThresholdSigningMultisigtests #442Issues fixed/closed:
Why it's needed:
Notes for reviewers: