Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the scikit learn restriction and bump minimal python version to 3.8 #233

Merged
merged 62 commits into from
Nov 8, 2023
Merged

Remove the scikit learn restriction and bump minimal python version to 3.8 #233

merged 62 commits into from
Nov 8, 2023

Conversation

otaviocv
Copy link
Contributor

@otaviocv otaviocv commented Aug 15, 2023 •
edited
Loading

Status

READY

Todo list

  • Documentation
  • Tests added and passed

Background context

fklearn had very old dependencies limiting the latest available features for many packages. With the increasing usage of M1 Macs working with these dependencies became an anoying issue. To overcome these and update fklearn we are making a major bump with all major packages bumped to their latest compatible version.

Description of the changes proposed in the pull request

Remaining problems or questions

  1. I wasn't able to bump the coverage packages.
  2. The hashing function changes behavior from 3.8 to 3.9. This makes a conditional test necessary for hash value tests.

@otaviocv otaviocv requested a review from a team as a code owner August 15, 2023 18:18
@otaviocv otaviocv changed the title Remove the scikit learn restriction Remove the scikit learn restriction and bump minimal python version to 3.0.0 Aug 15, 2023
@otaviocv otaviocv changed the title Remove the scikit learn restriction and bump minimal python version to 3.0.0 Remove the scikit learn restriction and bump minimal python version to 3.7 Aug 15, 2023
laoikeda
laoikeda reviewed Aug 22, 2023
View reviewed changes
Copy link

@laoikeda laoikeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Can you check why the tests are failing and write a description in the PR?

src/fklearn/resources/VERSION Outdated Show resolved Hide resolved
fpingas
fpingas suggested changes Aug 22, 2023
View reviewed changes
src/fklearn/resources/VERSION Outdated Show resolved Hide resolved
gcbeltramini
gcbeltramini reviewed Aug 22, 2023
View reviewed changes
requirements.txt Outdated Show resolved Hide resolved
@otaviocv otaviocv force-pushed the otaviocv/remove-scikit-0-25-constraint branch from 4cedd9e to 0432e56 Compare November 8, 2023 11:39
laoikeda
laoikeda reviewed Nov 8, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
tests/validation/test_evaluators.py Outdated Show resolved Hide resolved
@otaviocv otaviocv requested a review from laoikeda November 8, 2023 16:33
laoikeda
laoikeda approved these changes Nov 8, 2023
View reviewed changes
Copy link

@laoikeda laoikeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpingas fpingas changed the title Remove the scikit learn restriction and bump minimal python version to 3.7 Remove the scikit learn restriction and bump minimal python version to 3.8 Nov 8, 2023
@darlansf1 darlansf1 merged commit a302d91 into master Nov 8, 2023
5 checks passed
@darlansf1 darlansf1 deleted the otaviocv/remove-scikit-0-25-constraint branch November 8, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laoikeda laoikeda laoikeda approved these changes

@fpingas fpingas fpingas approved these changes

@gcbeltramini gcbeltramini Awaiting requested review from gcbeltramini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@otaviocv @gcbeltramini @fpingas @laoikeda @darlansf1