Skip to content

ci(perf): paginate sticky-comment lookup in both lanes #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mparrett wants to merge 1 commit into from
+6 −2
Open

ci(perf): paginate sticky-comment lookup in both lanes #715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/perf-pr-repeat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,9 @@ jobs:
// Resolved in the refs step so it works for both pull_request and
// workflow_dispatch (where there's no pull_request in the payload).
const issue_number = Number(process.env.PR);
const {data: comments} = await github.rest.issues.listComments({owner, repo, issue_number});
// paginate: the default page is 30, and a sticky upsert past that
// silently duplicates. Same call in perf-pr.yml.
const comments = await github.paginate(github.rest.issues.listComments, {owner, repo, issue_number});
const existing = comments.find(c => c.body && c.body.includes(marker));
if (existing) {
await github.rest.issues.updateComment({owner, repo, comment_id: existing.id, body});
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/perf-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,9 @@ jobs:
// Resolved in the refs step so it works for both pull_request and
// workflow_dispatch (where there's no pull_request in the payload).
const issue_number = Number(process.env.PR);
const {data: comments} = await github.rest.issues.listComments({owner, repo, issue_number});
// paginate: the default page is 30, and a sticky upsert past that
// silently duplicates. Same call in perf-pr-repeat.yml.
const comments = await github.paginate(github.rest.issues.listComments, {owner, repo, issue_number});
const existing = comments.find(c => c.body && c.body.includes(marker));
if (existing) {
await github.rest.issues.updateComment({owner, repo, comment_id: existing.id, body});
Expand Down
Loading