Skip to content

ci(perf): paginate sticky-comment lookup in both lanes - #715

Open
mparrett wants to merge 1 commit into
wt/perf-repeat-commentfrom
wt/sticky-paginate
Open

ci(perf): paginate sticky-comment lookup in both lanes#715
mparrett wants to merge 1 commit into
wt/perf-repeat-commentfrom
wt/sticky-paginate

Conversation

@mparrett

Copy link
Copy Markdown
Collaborator

Summary

  • Stacked on ci(perf-repeat): post the shadow-check report as a sticky PR comment #708. Fixes the pagination nit from the review there in both sticky-comment lanes (perf-pr.yml and perf-pr-repeat.yml), not just the new one.
  • github.rest.issues.listComments returns one page (30 by default). Past that the marker is missed and every run posts a fresh comment instead of updating the sticky one.
  • Switch both upserts to github.paginate(...) so the marker search covers the full comment list.

Test plan

Made with Cursor

@mparrett
mparrett requested a review from nnunley August 12, 2026 01:11
@mparrett
mparrett force-pushed the wt/sticky-paginate branch from c69af4b to 6cd221a Compare August 12, 2026 01:11
@mparrett
mparrett force-pushed the wt/sticky-paginate branch from 6cd221a to c851b7e Compare August 12, 2026 14:39
listComments defaults to 30 per page. Past that the marker is not found and
the "sticky" upsert silently creates a duplicate on every run. Flagged on
#708 for both lanes — this was inherited by the repeat comment job from
perf-pr.yml, so fix them together.

Co-authored-by: Cursor <cursoragent@cursor.com>
@mparrett
mparrett force-pushed the wt/sticky-paginate branch from c851b7e to eaaf7ed Compare August 13, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant