Repository navigation
docs(code-review): plan project-aware local review reset #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
djm81
wants to merge
9
commits into
dev
Choose a base branch
from
codex/code-review-reset-planning
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,773
−59
Open
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
fdfb514
docs(code-review): plan project-aware local review reset
djm81 798c31f
docs(code-review): record planning PR publication
djm81 f428eb5
docs(code-review): repair planning metadata and evidence links
djm81 1ce7d31
docs(code-review): tighten planning cutover and historical status
djm81 3543e89
docs(code-review): plan provisioned offline acceptance and evidence b…
djm81 f9aee41
docs(code-review): retire superseded capsule delivery directives
djm81 a71e448
docs(code-review): mark direct capsule guidance historical
djm81 325dcae
docs(code-review): gate stable publication on paired acceptance
djm81 0b5fea0
docs(code-review): gate release checklist on accepted candidate ident…
djm81 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| ts phase decision why evidence result | ||
| 2026-10-16T00:00:00+02:00 frame Deliver planning artifacts and GitHub alignment only The user explicitly leaves production implementation to follow-up sessions user-approved Replace capsules with project-aware local code review plan open | ||
| 2026-10-16T19:09:41.540133+00:00 github Created code-review-17-project-runtime-bootstrap Create the user-approved replacement story before retiring predecessors https://github.com/nold-ai/specfact-cli-modules/issues/513 planned | ||
| 2026-10-16T19:09:48.996899+00:00 github Created code-review-18-project-standards-and-checks Create the user-approved replacement story before retiring predecessors https://github.com/nold-ai/specfact-cli-modules/issues/514 planned | ||
| 2026-10-16T19:09:57.187959+00:00 github Created code-review-19-local-report-and-cutover Create the user-approved replacement story before retiring predecessors https://github.com/nold-ai/specfact-cli-modules/issues/515 planned | ||
| 2026-10-16T19:10:05.175425+00:00 github Created code-review-20-external-installation-acceptance Create the user-approved replacement story before retiring predecessors https://github.com/nold-ai/specfact-cli-modules/issues/516 planned | ||
| 2026-10-16T19:10:13.879369+00:00 github Created code-review-local-report-adoption Create the user-approved replacement story before retiring predecessors https://github.com/nold-ai/specfact-cli/issues/769 planned | ||
| 2026-10-16T19:10:31.140352+00:00 github Linked all five replacement stories Keep parent, project, type and direct dependencies explicit .audit/code-review-reset-state.json metadata configured | ||
| 2026-10-16T19:15:07.994829+00:00 correction Correct the initial trail timestamp Row 2 used a date-only placeholder at midnight rather than an observed execution time; subsequent entries use actual UTC timestamps .audit/code-review-reset.tsv:2 timestamp corrected by append-only note | ||
| 2026-10-16T19:15:07.994954+00:00 frame Created isolated artifact branches at current public dev baselines Keep production implementation and primary checkouts outside this planning delivery modules 593656f6; core 729a53bd VERIFIED branch bases | ||
| 2026-10-16T19:15:07.994995+00:00 artifacts Created four modules planning changes and paired core artifacts Make the approved architecture reviewable without implementing it openspec/changes/code-review-17-project-runtime-bootstrap/design.md runtime unverified; artifact validation pending | ||
| 2026-10-16T19:23:20.367503+00:00 verification Corrected core inspection scenario identifiers after real mapping validation failed The source validator resolves requirement-level scenario identities; the initial core sidecar used scenario titles instead /private/tmp/specfact-code-review-reset-core/openspec/changes/code-review-local-report-adoption/requirements-evidence.yaml initial failure retained; revalidation pending | ||
| 2026-10-16T19:29:00.526489+00:00 github Published the reviewed design and requirement scenarios in replacement issues Keep the public planning record reviewable while repository artifact branches remain local https://github.com/nold-ai/specfact-cli-modules/issues/513 planned artifacts published; no runtime claim | ||
| 2026-10-16T19:30:00.590855+00:00 verification Strict OpenSpec validation passed for the five new changes and touched active lineage Validate the saved requirements rather than claiming runtime support openspec validate <change-id> --strict; .audit/code-review-reset-structure.json VERIFIED planning structure only; existing core lineage has informational archive warnings | ||
| 2026-10-16T19:30:00.591015+00:00 verification Requirements lifecycle validation now passes for all five sources at planned maturity The corrected core scenario identifiers are checked by the actual source validator .audit/code-review-reset-requirements.json VERIFIED planned / proposal-only / implementation evidence not yet available | ||
| 2026-10-16T19:30:00.591061+00:00 review Independent artifact review accepted the architecture and requested one roadmap-count correction The reviewer read actual artifacts and retained failures rather than relying on completion claims openspec/CHANGE_ORDER.md:81; .audit/code-review-reset-structure.json count/date corrected; no architecture blocker; final GitHub readback pending | ||
| 2026-10-16T19:30:07.282373+00:00 github Published the reviewed design and requirement scenarios in replacement issues Keep the public planning record reviewable while repository artifact branches remain local https://github.com/nold-ai/specfact-cli-modules/issues/513 planned artifacts published; no runtime claim | ||
| 2026-10-16T19:30:33.815947+00:00 disposition Closed modules #460 as Not Planned The owner explicitly superseded remaining capsule delivery, preserving historical evidence https://github.com/nold-ai/specfact-cli-modules/issues/460 closed / not_planned / Rejected | ||
| 2026-10-16T19:30:39.753608+00:00 disposition Closed modules #488 as Not Planned The owner explicitly superseded remaining capsule delivery, preserving historical evidence https://github.com/nold-ai/specfact-cli-modules/issues/488 closed / not_planned / Rejected | ||
| 2026-10-16T19:30:45.948962+00:00 disposition Closed modules #495 as Not Planned The owner explicitly superseded remaining capsule delivery, preserving historical evidence https://github.com/nold-ai/specfact-cli-modules/issues/495 closed / not_planned / Rejected | ||
| 2026-10-16T19:30:52.040711+00:00 disposition Closed modules #512 as Not Planned The owner explicitly superseded remaining capsule delivery, preserving historical evidence https://github.com/nold-ai/specfact-cli-modules/issues/512 closed / not_planned / Rejected | ||
| 2026-10-16T19:30:58.406592+00:00 disposition Closed capsule PR #506 without merging The owner approved retiring the capsule repair/release queue https://github.com/nold-ai/specfact-cli-modules/pull/506 closed unmerged; branch preserved | ||
| 2026-10-16T19:31:05.887833+00:00 disposition Closed capsule PR #509 without merging The owner approved retiring the capsule repair/release queue https://github.com/nold-ai/specfact-cli-modules/pull/509 closed unmerged; branch preserved | ||
| 2026-10-16T19:31:11.906106+00:00 disposition Closed capsule PR #510 without merging The owner approved retiring the capsule repair/release queue https://github.com/nold-ai/specfact-cli-modules/pull/510 closed unmerged; branch preserved | ||
| 2026-10-16T19:31:24.503815+00:00 disposition Recorded explicit-test and C15/protected coordination without changing their status Retain independent acceptance and active ownership while aligning the replacement graph modules #480/#417; core #679/#680 coordination comments and #480 blocker configured | ||
| 2026-10-16T19:31:34.465658+00:00 verification Read back replacement metadata and predecessor dispositions from GitHub Check real states, direct edges and preserved ownership rather than inferring mutation success .audit/code-review-reset-github-after.json VERIFIED five stories, four not-planned closures, three unmerged PR closures and preserved independent metadata | ||
| 2026-10-16T19:35:18.534359+00:00 review Final independent recheck accepted artifact structure and saved GitHub evidence The reviewer checked counter corrections, exact preserved metadata, PR heads, planned mappings and unchecked tasks .audit/code-review-reset-github-after.json; openspec/changes/code-review-17-project-runtime-bootstrap/CHANGE_VALIDATION.md VERIFIED planning delivery; wiki merge prerequisite and runtime acceptance remain explicit | ||
| 2026-10-16T19:35:18.534544+00:00 handoff Preserved local artifact branches and public design/scenarios without runtime implementation Deliver reviewable planning work while leaving all 83 implementation tasks to follow-up sessions modules #513-#516; core #769; .audit/code-review-reset-core.patch artifact delivery complete; no commit, merge or publication | ||
| 2026-10-16T19:35:52.951332+00:00 clarification Public planning records are published; no runtime publication occurred Clarify the handoff row: publication refers to module/runtime release, not the GitHub issue design text https://github.com/nold-ai/specfact-cli-modules/issues/513 public design/scenarios retained; repository artifact branches local and uncommitted | ||
| 2026-10-16T19:45:40.412366+00:00 publication User authorized both planning branch commits, pushes and PRs to dev Keep runtime implementation in later sessions user instruction 2026-10-16 planning publication authorized; merge excluded | ||
| 2026-10-16T19:45:40.412550+00:00 wiki Aligned core source, C14/C15 notes, index and generated graph Finish the requested core wiki alignment while preserving unrelated dirty source pages core #769; native wiki health and graph scripts 0/12 implementation tasks; 59 pre-existing errors vs baseline 62; no new errors; 169 unrelated pages unchanged | ||
| 2026-10-16T19:45:40.412598+00:00 worktree Moved the core planning worktree from temporary storage to a durable task branch location The wiki must cite the real public proposal without relying on temporary storage core branch codex/code-review-local-report-planning worktree and all uncommitted planning artifacts preserved | ||
| 2026-10-16T19:45:40.412640+00:00 forge Resolved GitHub and the built-in PR creation tool Origin is absent; use gh for readback and the connector for PR creation command -v origin; github_create_pull_request GitHub CLI readback with built-in PR creation | ||
| 2026-10-16T19:46:14.877680+00:00 verification Read back replacement metadata and predecessor dispositions from GitHub Check real states, direct edges and preserved ownership rather than inferring mutation success .audit/code-review-reset-github-after.json VERIFIED five stories, four not-planned closures, three unmerged PR closures and preserved independent metadata | ||
| 2026-10-16T19:46:47.993388+00:00 review Completed bounded no-comments and own deslop checks PR playbook requires a comment pass before review and artifact cleanup before commit read-only planning_pr_comment_review; inspected both HEAD-relative diffs 0 deletions; 0 MUST KILL flags; all scoped production paths unchanged | ||
| 2026-10-16T19:46:47.993631+00:00 verification Refreshed both dev references and strictly revalidated all five changes Publish against the actual current dev baselines git fetch origin dev; openspec validate --strict both branch bases remain exact dev; five strict passes; live issue graph and dispositions reverified | ||
| 2026-10-16T19:49:40.297238+00:00 verification Normal applicable staged hooks passed in both repositories Use native evidence and preserve existing signature/security checks modules pre-commit run with paired core; core pre-commit with pinned fixture modules 28 contract tests passed; planned evidence passed both; no replacement runtime claimed; existing core YAML errors remain outside scope | ||
| 2026-10-16T19:49:40.297535+00:00 signing Core signed commit failed after applicable hooks passed No signing secret key is available for the configured author; do not bypass required signing git commit -S; gpg No secret key; docs/agent-rules/70-release-commit-and-docs.md files remain staged; requested existing signing configuration; push and PR creation wait for signed commits | ||
| 2026-10-16T19:50:31.413835+00:00 signing Resolved the signing failure to unselected key and mismatched author email The user authorized using the existing official local key; elevated metadata lookup found both keys GitHub users/djm81/gpg_keys; verified noreply signing key D90AAF92921066C1 select existing key and matching noreply email per commit; no global settings changed; signing retry pending |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
openspec/changes/code-review-15-signal-calibrated-blocking-gate/design.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.