Skip to content

docs(code-review): plan project-aware local review reset #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
djm81 wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

docs(code-review): plan project-aware local review reset #517

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fdfb514
docs(code-review): plan project-aware local review reset
djm81 Oct 16, 2026
798c31f
docs(code-review): record planning PR publication
djm81 Oct 16, 2026
f428eb5
docs(code-review): repair planning metadata and evidence links
djm81 Oct 16, 2026
1ce7d31
docs(code-review): tighten planning cutover and historical status
djm81 Oct 16, 2026
3543e89
docs(code-review): plan provisioned offline acceptance and evidence b…
djm81 Oct 16, 2026
f9aee41
docs(code-review): retire superseded capsule delivery directives
djm81 Oct 16, 2026
a71e448
docs(code-review): mark direct capsule guidance historical
djm81 Oct 16, 2026
325dcae
docs(code-review): gate stable publication on paired acceptance
djm81 Oct 16, 2026
0b5fea0
docs(code-review): gate release checklist on accepted candidate ident…
djm81 Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2,052 changes: 2,052 additions & 0 deletions .audit/code-review-reset-validation.json
View file
Open in desktop

Large diffs are not rendered by default.

49 changes: 49 additions & 0 deletions .audit/code-review-reset.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
ts phase decision why evidence result
2026-10-16T00:00:00+02:00 frame Deliver planning artifacts and GitHub alignment only The user explicitly leaves production implementation to follow-up sessions user-approved Replace capsules with project-aware local code review plan open
2026-10-16T19:09:41.540133+00:00 github Created code-review-17-project-runtime-bootstrap Create the user-approved replacement story before retiring predecessors https://github.com/nold-ai/specfact-cli-modules/issues/513 planned
2026-10-16T19:09:48.996899+00:00 github Created code-review-18-project-standards-and-checks Create the user-approved replacement story before retiring predecessors https://github.com/nold-ai/specfact-cli-modules/issues/514 planned
2026-10-16T19:09:57.187959+00:00 github Created code-review-19-local-report-and-cutover Create the user-approved replacement story before retiring predecessors https://github.com/nold-ai/specfact-cli-modules/issues/515 planned
2026-10-16T19:10:05.175425+00:00 github Created code-review-20-external-installation-acceptance Create the user-approved replacement story before retiring predecessors https://github.com/nold-ai/specfact-cli-modules/issues/516 planned
2026-10-16T19:10:13.879369+00:00 github Created code-review-local-report-adoption Create the user-approved replacement story before retiring predecessors https://github.com/nold-ai/specfact-cli/issues/769 planned
2026-10-16T19:10:31.140352+00:00 github Linked all five replacement stories Keep parent, project, type and direct dependencies explicit .audit/code-review-reset-state.json metadata configured
2026-10-16T19:15:07.994829+00:00 correction Correct the initial trail timestamp Row 2 used a date-only placeholder at midnight rather than an observed execution time; subsequent entries use actual UTC timestamps .audit/code-review-reset.tsv:2 timestamp corrected by append-only note
2026-10-16T19:15:07.994954+00:00 frame Created isolated artifact branches at current public dev baselines Keep production implementation and primary checkouts outside this planning delivery modules 593656f6; core 729a53bd VERIFIED branch bases
2026-10-16T19:15:07.994995+00:00 artifacts Created four modules planning changes and paired core artifacts Make the approved architecture reviewable without implementing it openspec/changes/code-review-17-project-runtime-bootstrap/design.md runtime unverified; artifact validation pending
2026-10-16T19:23:20.367503+00:00 verification Corrected core inspection scenario identifiers after real mapping validation failed The source validator resolves requirement-level scenario identities; the initial core sidecar used scenario titles instead /private/tmp/specfact-code-review-reset-core/openspec/changes/code-review-local-report-adoption/requirements-evidence.yaml initial failure retained; revalidation pending
2026-10-16T19:29:00.526489+00:00 github Published the reviewed design and requirement scenarios in replacement issues Keep the public planning record reviewable while repository artifact branches remain local https://github.com/nold-ai/specfact-cli-modules/issues/513 planned artifacts published; no runtime claim
2026-10-16T19:30:00.590855+00:00 verification Strict OpenSpec validation passed for the five new changes and touched active lineage Validate the saved requirements rather than claiming runtime support openspec validate <change-id> --strict; .audit/code-review-reset-structure.json VERIFIED planning structure only; existing core lineage has informational archive warnings
2026-10-16T19:30:00.591015+00:00 verification Requirements lifecycle validation now passes for all five sources at planned maturity The corrected core scenario identifiers are checked by the actual source validator .audit/code-review-reset-requirements.json VERIFIED planned / proposal-only / implementation evidence not yet available
2026-10-16T19:30:00.591061+00:00 review Independent artifact review accepted the architecture and requested one roadmap-count correction The reviewer read actual artifacts and retained failures rather than relying on completion claims openspec/CHANGE_ORDER.md:81; .audit/code-review-reset-structure.json count/date corrected; no architecture blocker; final GitHub readback pending
2026-10-16T19:30:07.282373+00:00 github Published the reviewed design and requirement scenarios in replacement issues Keep the public planning record reviewable while repository artifact branches remain local https://github.com/nold-ai/specfact-cli-modules/issues/513 planned artifacts published; no runtime claim
2026-10-16T19:30:33.815947+00:00 disposition Closed modules #460 as Not Planned The owner explicitly superseded remaining capsule delivery, preserving historical evidence https://github.com/nold-ai/specfact-cli-modules/issues/460 closed / not_planned / Rejected
2026-10-16T19:30:39.753608+00:00 disposition Closed modules #488 as Not Planned The owner explicitly superseded remaining capsule delivery, preserving historical evidence https://github.com/nold-ai/specfact-cli-modules/issues/488 closed / not_planned / Rejected
2026-10-16T19:30:45.948962+00:00 disposition Closed modules #495 as Not Planned The owner explicitly superseded remaining capsule delivery, preserving historical evidence https://github.com/nold-ai/specfact-cli-modules/issues/495 closed / not_planned / Rejected
2026-10-16T19:30:52.040711+00:00 disposition Closed modules #512 as Not Planned The owner explicitly superseded remaining capsule delivery, preserving historical evidence https://github.com/nold-ai/specfact-cli-modules/issues/512 closed / not_planned / Rejected
2026-10-16T19:30:58.406592+00:00 disposition Closed capsule PR #506 without merging The owner approved retiring the capsule repair/release queue https://github.com/nold-ai/specfact-cli-modules/pull/506 closed unmerged; branch preserved
2026-10-16T19:31:05.887833+00:00 disposition Closed capsule PR #509 without merging The owner approved retiring the capsule repair/release queue https://github.com/nold-ai/specfact-cli-modules/pull/509 closed unmerged; branch preserved
2026-10-16T19:31:11.906106+00:00 disposition Closed capsule PR #510 without merging The owner approved retiring the capsule repair/release queue https://github.com/nold-ai/specfact-cli-modules/pull/510 closed unmerged; branch preserved
2026-10-16T19:31:24.503815+00:00 disposition Recorded explicit-test and C15/protected coordination without changing their status Retain independent acceptance and active ownership while aligning the replacement graph modules #480/#417; core #679/#680 coordination comments and #480 blocker configured
2026-10-16T19:31:34.465658+00:00 verification Read back replacement metadata and predecessor dispositions from GitHub Check real states, direct edges and preserved ownership rather than inferring mutation success .audit/code-review-reset-github-after.json VERIFIED five stories, four not-planned closures, three unmerged PR closures and preserved independent metadata
2026-10-16T19:35:18.534359+00:00 review Final independent recheck accepted artifact structure and saved GitHub evidence The reviewer checked counter corrections, exact preserved metadata, PR heads, planned mappings and unchecked tasks .audit/code-review-reset-github-after.json; openspec/changes/code-review-17-project-runtime-bootstrap/CHANGE_VALIDATION.md VERIFIED planning delivery; wiki merge prerequisite and runtime acceptance remain explicit
2026-10-16T19:35:18.534544+00:00 handoff Preserved local artifact branches and public design/scenarios without runtime implementation Deliver reviewable planning work while leaving all 83 implementation tasks to follow-up sessions modules #513-#516; core #769; .audit/code-review-reset-core.patch artifact delivery complete; no commit, merge or publication
2026-10-16T19:35:52.951332+00:00 clarification Public planning records are published; no runtime publication occurred Clarify the handoff row: publication refers to module/runtime release, not the GitHub issue design text https://github.com/nold-ai/specfact-cli-modules/issues/513 public design/scenarios retained; repository artifact branches local and uncommitted
2026-10-16T19:45:40.412366+00:00 publication User authorized both planning branch commits, pushes and PRs to dev Keep runtime implementation in later sessions user instruction 2026-10-16 planning publication authorized; merge excluded
2026-10-16T19:45:40.412550+00:00 wiki Aligned core source, C14/C15 notes, index and generated graph Finish the requested core wiki alignment while preserving unrelated dirty source pages core #769; native wiki health and graph scripts 0/12 implementation tasks; 59 pre-existing errors vs baseline 62; no new errors; 169 unrelated pages unchanged
2026-10-16T19:45:40.412598+00:00 worktree Moved the core planning worktree from temporary storage to a durable task branch location The wiki must cite the real public proposal without relying on temporary storage core branch codex/code-review-local-report-planning worktree and all uncommitted planning artifacts preserved
2026-10-16T19:45:40.412640+00:00 forge Resolved GitHub and the built-in PR creation tool Origin is absent; use gh for readback and the connector for PR creation command -v origin; github_create_pull_request GitHub CLI readback with built-in PR creation
2026-10-16T19:46:14.877680+00:00 verification Read back replacement metadata and predecessor dispositions from GitHub Check real states, direct edges and preserved ownership rather than inferring mutation success .audit/code-review-reset-github-after.json VERIFIED five stories, four not-planned closures, three unmerged PR closures and preserved independent metadata
2026-10-16T19:46:47.993388+00:00 review Completed bounded no-comments and own deslop checks PR playbook requires a comment pass before review and artifact cleanup before commit read-only planning_pr_comment_review; inspected both HEAD-relative diffs 0 deletions; 0 MUST KILL flags; all scoped production paths unchanged
2026-10-16T19:46:47.993631+00:00 verification Refreshed both dev references and strictly revalidated all five changes Publish against the actual current dev baselines git fetch origin dev; openspec validate --strict both branch bases remain exact dev; five strict passes; live issue graph and dispositions reverified
2026-10-16T19:49:40.297238+00:00 verification Normal applicable staged hooks passed in both repositories Use native evidence and preserve existing signature/security checks modules pre-commit run with paired core; core pre-commit with pinned fixture modules 28 contract tests passed; planned evidence passed both; no replacement runtime claimed; existing core YAML errors remain outside scope
2026-10-16T19:49:40.297535+00:00 signing Core signed commit failed after applicable hooks passed No signing secret key is available for the configured author; do not bypass required signing git commit -S; gpg No secret key; docs/agent-rules/70-release-commit-and-docs.md files remain staged; requested existing signing configuration; push and PR creation wait for signed commits
2026-10-16T19:50:31.413835+00:00 signing Resolved the signing failure to unselected key and mismatched author email The user authorized using the existing official local key; elevated metadata lookup found both keys GitHub users/djm81/gpg_keys; verified noreply signing key D90AAF92921066C1 select existing key and matching noreply email per commit; no global settings changed; signing retry pending
2026-10-16T19:52:27.318050+00:00 publication Both signed planning commits were pushed and both ready PRs opened against dev Finish the explicit user publication request without runtime implementation modules #517 at fdfb514e; core #770 at ab9bbc57 GitHub verifies both signatures as valid; both open and non-draft; runtime paths unchanged; 83 implementation tasks unchecked
2026-10-16T19:52:27.318351+00:00 verification Read back PR bases, exact heads, file lists and signature status from GitHub Apply Prove It Works to actual published artifacts gh pr view 517/770; GitHub commits verification 44 modules planning/audit paths and 10 core OpenSpec paths; no runtime implementation; both PRs attached to this chat
2026-10-16T20:09:40.821074+00:00 review Validated and corrected planning feedback in both PRs Real parser and path probes reproduced the reported failures; keep runtime out of scope modules #517; core #770; planning probe failure/pass native proposal metadata and moved references corrected; C15 routing and installation ownership clarified; 84 future tasks unchecked
2026-10-16T20:09:40.821272+00:00 evidence Published a compact actual-observation receipt The prior validation document named local-only scratch files; reviewers need committed evidence .audit/code-review-reset-validation.json original mapping failure, current planned inspection, public before/after dispositions and before/after planning probes are included
2026-10-16T20:13:13.153719+00:00 review Independent follow-up review passed before push Check actual parser results, projected evidence, source locators and planned counts planning_review_followup; source probes; fresh lifecycle evaluation 23 requirements; 51 scenarios; 84 unchecked tasks; no runtime, CI or dependency changes
2026-10-16T20:13:13.153938+00:00 ci Classified unchanged-base CI failures rather than retrying them The planning diff does not own runtime dependency or smoke fixture behavior modules quality jobs 117168732462/463/709; core jobs 117165752487/117165944008 module core pin 0.55.4 vs installed 0.55.10 and smoke identity mismatch; core frozen MCP advisory and missing exact-tree authority remain independent
2026-10-16T20:25:23.589497+00:00 review Reproduced and corrected the next six planning findings Complete schema admission and implementation sequencing, and prevent abandoned Apple guidance from appearing active Codex discussions 4298946574 and 4298953919/3938/3943/3959/3965; round-2 before/after probes 23 requirements; 52 scenarios; 86 future tasks unchecked; strict validation and planned lifecycle pass
2026-10-16T20:25:23.589713+00:00 ci Tracked baseline failures without weakening gates Separate existing CI maintenance from architecture planning modules #518; core #747; organization policy pinned 0787cc7e existing module CI failures and core upstream dependency block remain; CodeRabbit limits are not a clean review
2026-10-16T20:39:01.222520+00:00 review-round-3 Bind future behavior evidence and accept provisioned offline execution Current core review identified inspection-only future GREEN and missing already-provisioned offline acceptance; preserve the existing local/offline use case without promising cold offline bootstrap Core current review 4299061082/4299061092; round3 planning probe fails before and passes after; five-source lifecycle and strict validators pass; wiki errors unchanged Planning only: 23 requirements, 54 mapped inspection cases, 86 unchecked tasks; no runtime, dependency or CI edits
2026-10-16T20:43:32.015608+00:00 review-round-4 Retire capsule sequencing directives and require final fresh review Later reviews of previous heads found active language in historical ordering and stale-review risk after versioning Actual historical-section/task-order probe failed before and passed after; retired records preserve delivered evidence, C15 ownership and independent gates Planning-only follow-up; no task completion or runtime change
Loading
Loading