fix gpx file parsing #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`to_polygon` always closes the list of parsed GPX points inside the GPXFile object. Since it is used while parsing the GPX file it always resulted in a closed list of GPX points even if that was not the case.
|
Going to give this some love today. Thank you! |
|
Great, thanks! |
|
I know this gem is not that active in development, but I think it's great and it solves a lot of problems for me. So thank you for making it! Is there any chance to get this PR merged? I can confirm the issue and this PR works for me like a charm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to_polygonalways closes the list of parsedGPX points inside the GPXFile object.
Since it is used while parsing the GPX file it always
resulted in a closed list of GPX points even if that
was not the case.