Don't close GPX polylines #57
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 22, 2022
| # to the last point will be created to close it. | ||
| def as_polygon | ||
| GeoRuby::SimpleFeatures::Polygon.from_points([@points[0] == @points[-1] ? @points : @points.push(@points[0].clone)]) | ||
| GeoRuby::SimpleFeatures::Polygon.from_points([@points[0] == @points[-1] ? @points : (@points + [@points[0]])]) |
There was a problem hiding this comment.
Layout/SpaceAroundOperators: Operator ? should be surrounded by a single space.
Metrics/LineLength: Line is too long. [119/80]
Layout/ExtraSpacing: Unnecessary spacing detected.
|
Ah, duplicate of #38! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
as_polygonmethod usesArray.pushto add an extra point to close the shape.Array.pushdoes of course modify the original array in-place. Sinceas_polygonis called byenvelope, andenvelopeis called byparse_file, this means all polylines are erroneously turned into closed polygons on parsing.This PR fixes this by using
+instead ofArray.push.